Merge pull request #1341 from zm711/fix-ascii-test-windows

apdavison · web-flow · commit a36df30659a3 · 2023-10-23T09:59:42.000+02:00
Fix `test_asciisignalio` to work on Windows
diff --git a/neo/test/iotest/test_asciisignalio.py b/neo/test/iotest/test_asciisignalio.py
@@ -55,7 +55,7 @@ def test_csv_expect_success(self):
             (-64.6, -64.2, -77.0, 0.7),
             (-64.3, -64.0, -99.9, 0.8)
         ]
-        with open(filename, 'w') as csvfile:
+        with open(filename, 'w', newline='') as csvfile:
             writer = csv.writer(csvfile, delimiter=',',
                                 quotechar='|', quoting=csv.QUOTE_MINIMAL)
             for row in sample_data:

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ def test_csv_expect_success(self):`
`55`	`55`	`(-64.6, -64.2, -77.0, 0.7),`
`56`	`56`	`(-64.3, -64.0, -99.9, 0.8)`
`57`	`57`	`]`
`58`		`- with open(filename, 'w') as csvfile:`
	`58`	`+ with open(filename, 'w', newline='') as csvfile:`
`59`	`59`	`writer = csv.writer(csvfile, delimiter=',',`
`60`	`60`	`quotechar='\|', quoting=csv.QUOTE_MINIMAL)`
`61`	`61`	`for row in sample_data:`