feat: 1차 UT QA 홈 페이지 반영 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bsy1141
approved these changes
Feb 11, 2025
| import { Suspense } from 'react'; | ||
|
|
||
| export default function ReportQuestionsLayout({ children }: PropsWithChildren) { | ||
| return <Suspense>{children}</Suspense>; |
There was a problem hiding this comment.
굿 나도 요렇게 바꿔야겠다 fallback으로 로딩뷰 여기다 넣어주는게 좀 더 깔끔할 수도 있겠다
페이지 전체적으로 이렇게 적용할 생각이야?
There was a problem hiding this comment.
next 에서 loading 페이지 만들어주면 next 자동으로 suspense 랑 fallback 알아서 해주는 걸루 알고있어! 그래서 로딩 관련해서는 loading.tsx 페이지만 적절히 만들어주면 될 거 같어
| @@ -53,12 +64,16 @@ export default function ReportQuestions() { | |||
| <div className={styles.contentContainer}> | |||
There was a problem hiding this comment.
수민이 작업과 아주 무관하게.. 카드 개수가 많아지면 맨 아래 카드가 안보이는 오류가 있는 것 같당
contentContainer에 margin-bottom 적당히 필요할 듯..
요 페이지 내 스크롤 이벤트도 좀 문제가 있는데 고칠필요는 없고 우리끼리 인지하고 있다가 고치면 될듯!
아예 들어가는 느낌으로 수정해봐볼게~!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣반영 브랜치
feat/#53 -> main, close #53
📝작업 내용
Toast 공통 컴포넌트 추가
useToast공통 훅 생성아래와 같이 호출해주면 됩니다!
스크린샷 (선택)
💬리뷰 요구사항(선택)