Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the dummy keys to /examples/mina-zk-app #93

Open
alexandra-mara opened this issue Jul 31, 2023 · 1 comment
Open

Return the dummy keys to /examples/mina-zk-app #93

alexandra-mara opened this issue Jul 31, 2023 · 1 comment

Comments

@alexandra-mara
Copy link
Contributor

alexandra-mara commented Jul 31, 2023

Right now we're describing updating keys for mina-zk-app in our documentation and zkApp's readme, but the keys folder was removed from the repo and added to .gitignore some time ago. I suggest we add sample files keys/berkeley.json and keys/user.json, so users would know exactly what is supposed to be in these files. Something like this:

{
  "privateKey": "YOUR_PRIVATE_KEY",
  "publicKey": "YOUR_PUBLIC_KEY"
}
@NickVolynkin
Copy link

It's a dangerous practice because, in the end, people will accidentally commit their secrets and push them to GitHub. The best we can do is keep the directory by adding an empty .gitkeep file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants