Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set version of notebooks automatically to latest #33

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

jcabrero
Copy link
Member

@jcabrero jcabrero commented Aug 7, 2024

No description provided.

Copy link
Contributor

@mathias-nillion mathias-nillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left a small thought. LMK what you think

@@ -60,7 +60,7 @@
},
"outputs": [],
"source": [
"%pip install nada-ai~=0.3.0 --quiet"
"%pip install nada-ai --quiet"
Copy link
Contributor

@mathias-nillion mathias-nillion Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcabrero should we instead solve this by specifying a version for both nada and nada-ai? Here we implicitly assume that nada-ai:latest will always work with nada:latest and the specific logic in this notebook

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a hard question. There are pros/cons for each of those and it's hard to tell. I would argue that always being par with nada-dsl is what requires the least work as the API should slowly settle down. However, if we fix versions, every two weeks (or once there's a new release) we need to dedicate a whole morning at least to update all the versions manually and verify that everything works. Not sure what's best here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this for now, but it's a good discussion to have and see what's best.

@jcabrero jcabrero merged commit a89de2c into main Aug 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants