Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace _seeds with HKDF #7

Merged
merged 3 commits into from
Feb 16, 2025
Merged

feat: replace _seeds with HKDF #7

merged 3 commits into from
Feb 16, 2025

Conversation

jimouris
Copy link
Member

If a seed is provided to _random_bytes we use HKDF, otherwise, we use secrets.token_bytes as before.

@jimouris jimouris requested a review from lapets February 12, 2025 18:16
Copy link

github-actions bot commented Feb 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 92.02% 715 / 777
🔵 Statements 92.02% 715 / 777
🔵 Functions 91.66% 33 / 36
🔵 Branches 91.94% 217 / 236
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/nilql.ts 93.46% 92.34% 94.28% 93.46% 110-111, 114-117, 226-229, 262, 283-287, 419-422, 457-458, 627-628, 731-732, 762-765, 857-858, 887-890, 912-913, 957-960, 978-981, 994-995, 1046, 1078-1079
Generated in workflow #35 for commit 3fd24eb by the Vitest Coverage Report Action

@jimouris jimouris changed the title feat: replace with HKDF feat: replace _seeds with HKDF Feb 12, 2025
@jimouris jimouris changed the base branch from main to 0.0.0-alpha.11 February 13, 2025 18:40
@lapets lapets merged commit 8fd115b into 0.0.0-alpha.11 Feb 16, 2025
@lapets lapets deleted the feat/hkdf branch February 16, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants