Merge #33

33: feat: eddsa signing protocol r=jfdreis a=jfdreis

Implementation of the State Machines for the EdDSA signature

## Motivation

<!--
Explain the context and why you're making that change. What is the problem
you're trying to solve? In some cases there is not a problem and this can be
thought of as being the motivation for your change.
-->

## Solution

<!--
Summarize the solution and provide any necessary context needed to understand
the code change.
-->


Fixes #
Design discussion issue (if applicable) #

## Merge requirement checklist

* [ ] [CONTRIBUTING](https://github.com/NillionNetwork/nillion/blob/main/CONTRIBUTING.md) guidelines followed
* [x] Unit tests added/updated (if applicable)
* [ ] Breaking change analysis completed (if applicable). "Will this change require all network cluster operators to update? Does it break public APIs?"
* [ ] For new features or breaking changes, created a documentation issue in [nillion-docs](https://github.com/NillionNetwork/nillion-docs/issues/new/choose)


Co-authored-by: jfdreis <[email protected]>

libs/client-core/Cargo.toml

@@ -4,7 +4,7 @@ version = "0.1.0"
 edition = "2021"
 
 [dependencies]
-key-share = { version = "0.5.0", default-features = false, features = ["spof"] }
+key-share = { version = "0.6.0", default-features = false, features = ["spof"] }
 
 basic-types = { path = "../basic-types" }
 threshold-keypair = { path = "../../libs/threshold-keypair", default-features = false }

libs/execution-engine/mpc-vm/Cargo.toml

@@ -31,7 +31,7 @@ rstest = "0.21.0"
 serde = { version = "1", features = ["derive"] }
 test-programs = { path = "../../../nada-lang/test-programs" }
 mpc-vm = { path = ".", features = ["simulator"] }
-cggmp21 = { version = "0.5.0", features = ["curve-secp256k1"] }
+cggmp21 = { version = "0.6.0", features = ["curve-secp256k1"] }
 
 [features]
 default = []

libs/nada-value/Cargo.toml

@@ -7,7 +7,7 @@ edition = "2021"
 anyhow = "1.0.86"
 enum-as-inner = "0.6.1"
 indexmap = { version = "2.6.0" }
-key-share = { version = "0.5.0", default-features = false, features = ["spof"] }
+key-share = { version = "0.6.0", default-features = false, features = ["spof"] }
 generic-ec = { version = "0.4.2", default-features = false, features = ["alloc", "curve-secp256k1"] }
 givre = { version = "0.2.0", features = ["ciphersuite-secp256k1", "ciphersuite-ed25519", "spof", "cggmp21-keygen"] }
 num-bigint = "0.4.6"

libs/protocols/Cargo.toml

@@ -6,12 +6,12 @@ edition = "2021"
 [dependencies]
 anyhow = "1"
 itertools = "0.13"
-key-share = { version = "0.5.0", default-features = false, features = ["spof"] }
+key-share = { version = "0.6.0", default-features = false, features = ["spof"] }
 num-bigint = "0.4"
 rand = "0.8"
 rand_chacha = "0.3.1"
 rayon = { version = "1.10", optional = true }
-round-based = "0.3"
+round-based = "0.4"
 serde = { version = "1", features = ["derive"] }
 thiserror = "1"
 uuid = { version = "1.10", features = ["v4"], optional = true }
@@ -24,12 +24,14 @@ state-machine-derive = { path = "../state-machine-derive" }
 state-machine-macros = { path = "../state-machine-macros" }
 
 threshold-keypair = { path = "../threshold-keypair" }
-cggmp21 = { version = "0.5.0", features = ["curve-secp256k1", "state-machine"] }
+cggmp21 = { version = "0.6.0", features = ["curve-secp256k1", "state-machine"] }
 gmp-mpfr-sys = { version = "1.6.4", features = ["force-cross"] }
 sha2 = "0.10"
 serde_json = "1"
 once_cell = "1.20.1"
 
+givre = { version = "0.2.0", features = ["ciphersuite-ed25519", "full-signing", "serde" ] }
+
 [dev-dependencies]
 criterion = "0.5.1"
 num-bigint = "0.4.6"

libs/protocols/src/lib.rs

@@ -22,6 +22,7 @@ pub mod multiplication;
 pub mod random;
 pub mod reveal;
 pub mod threshold_ecdsa;
+pub mod threshold_eddsa;
 
 #[cfg(any(test, feature = "validation"))]
 pub mod simulator;

libs/protocols/src/threshold_ecdsa/signing/test.rs

@@ -59,7 +59,7 @@ impl EcdsaSignProtocol {
 
 impl Protocol for EcdsaSignProtocol {
     type State = EcdsaSignState;
-    type PrepareOutput = EcdsSignConfig;
+    type PrepareOutput = EcdsaSignConfig;
 
     fn prepare(&self, parties: &[PartyId]) -> Result<Self::PrepareOutput, Error> {
         let sorted_parties = SortedParties::new(parties.to_vec());
@@ -76,7 +76,7 @@ impl Protocol for EcdsaSignProtocol {
             private_key_shares.insert(party_id.clone(), pk_share.clone());
         }
 
-        Ok(EcdsSignConfig {
+        Ok(EcdsaSignConfig {
             eid: self.eid.clone(),
             parties: parties.to_vec(),
             private_key_shares,
@@ -112,7 +112,7 @@ impl Protocol for EcdsaSignProtocol {
 }
 
 /// The internal configuration of a EcdsSignConfig protocol.
-struct EcdsSignConfig {
+struct EcdsaSignConfig {
     eid: Vec<u8>,
     parties: Vec<PartyId>,
     private_key_shares: PartyShares<ThresholdPrivateKeyShare<Secp256k1>>,

libs/protocols/src/threshold_eddsa/README.md

@@ -0,0 +1,4 @@
+# Signing protocol
+
+- This protocol is the main singing protocol of the FROST EdDSA Signing protocol from the [givre](https://docs.rs/givre/latest/givre/index.html) library. 
+- It generates a signature that is sent to the client.

libs/protocols/src/threshold_eddsa/mod.rs

@@ -0,0 +1,12 @@
+//! Threshold EdDSA protocol
+pub mod output;
+pub mod state;
+
+pub use state::*;
+#[cfg(test)]
+pub mod test;
+
+use state_machine::StateMachine;
+
+/// The Eddsa Signing state machine.
+pub type EddsaSignStateMachine = StateMachine<EddsaSignState>;

libs/protocols/src/threshold_eddsa/output.rs

@@ -0,0 +1,28 @@
+//! Outputs for the EdDSA signing protocol.
+use givre::signing::round2::SigningError;
+use std::fmt::Display;
+use threshold_keypair::signature::EddsaSignature;
+
+/// The EdDSA signing output.
+pub enum EddsaSignatureOutput {
+    /// The protocol was successful.
+    Success {
+        /// The output elements.
+        element: EddsaSignature,
+    },
+
+    /// This or a subprotocol aborted by chance.
+    Abort {
+        /// The reason why it aborted
+        reason: SigningError,
+    },
+}
+
+impl Display for EddsaSignatureOutput {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            Self::Success { .. } => write!(f, "Success"),
+            Self::Abort { .. } => write!(f, "Abort"),
+        }
+    }
+}