Skip to content

Commit

Permalink
treewide: remove uneccessary uses of dotnetCorePacakges.combinePacakges
Browse files Browse the repository at this point in the history
  • Loading branch information
corngood committed Dec 5, 2024
1 parent 0dcba5f commit abd7695
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 18 deletions.
5 changes: 1 addition & 4 deletions pkgs/by-name/be/beatsabermodmanager/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ buildDotnetModule rec {
fetchSubmodules = true; # It vendors BSIPA-Linux
};

dotnet-sdk = with dotnetCorePackages; combinePackages [
sdk_7_0
sdk_6_0
];
dotnet-sdk = dotnetCorePackages.sdk_7_0;

dotnet-runtime = dotnetCorePackages.runtime_7_0;

Expand Down
9 changes: 4 additions & 5 deletions pkgs/by-name/fs/fsautocomplete/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,10 @@ buildDotnetModule (finalAttrs: rec {

dotnet-sdk =
with dotnetCorePackages;
combinePackages [
sdk_6_0
sdk_7_0
sdk_8_0
];
sdk_8_0
// {
inherit (sdk_6_0) packages targetPackages;
};
dotnet-runtime = dotnetCorePackages.sdk_8_0;

projectFile = "src/FsAutoComplete/FsAutoComplete.fsproj";
Expand Down
7 changes: 1 addition & 6 deletions pkgs/by-name/ga/garnet/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,7 @@ buildDotnetModule rec {
projectFile = "main/GarnetServer/GarnetServer.csproj";
nugetDeps = ./deps.nix;

dotnet-sdk =
with dotnetCorePackages;
combinePackages [
sdk_6_0
sdk_8_0
];
dotnet-sdk = dotnetCorePackages.sdk_8_0;
dotnet-runtime = dotnetCorePackages.runtime_8_0;

dotnetBuildFlags = [
Expand Down
14 changes: 13 additions & 1 deletion pkgs/by-name/na/naps2/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,19 @@ buildDotnetModule rec {

executables = [ "naps2" ];

dotnet-sdk = with dotnetCorePackages; combinePackages [ sdk_6_0 sdk_8_0 ];
dotnet-sdk =
with dotnetCorePackages;
sdk_8_0
// {
inherit
(combinePackages [
sdk_8_0
sdk_6_0
])
packages
targetPackages
;
};
dotnet-runtime = dotnetCorePackages.runtime_8_0;
selfContainedBuild = true;
runtimeDeps = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ buildDotnetModule rec {
updateScript = ./update.sh;
};

# SDK 6.0 required for Robust.LoaderApi
dotnet-sdk = with dotnetCorePackages; combinePackages [ sdk_8_0 sdk_6_0 ];
dotnet-sdk = dotnetCorePackages.sdk_8_0;
dotnet-runtime = dotnetCorePackages.runtime_8_0;

dotnetFlags = [
Expand Down

0 comments on commit abd7695

Please sign in to comment.