From abd7695ad57bf17e7eb3fbfbd73bf953a95ebd8d Mon Sep 17 00:00:00 2001 From: David McFarland Date: Sun, 27 Oct 2024 13:43:47 -0300 Subject: [PATCH] treewide: remove uneccessary uses of dotnetCorePacakges.combinePacakges --- pkgs/by-name/be/beatsabermodmanager/package.nix | 5 +---- pkgs/by-name/fs/fsautocomplete/package.nix | 9 ++++----- pkgs/by-name/ga/garnet/package.nix | 7 +------ pkgs/by-name/na/naps2/package.nix | 14 +++++++++++++- .../space-station-14-launcher.nix | 3 +-- 5 files changed, 20 insertions(+), 18 deletions(-) diff --git a/pkgs/by-name/be/beatsabermodmanager/package.nix b/pkgs/by-name/be/beatsabermodmanager/package.nix index 42e1f738e470f..051f11c519a9a 100644 --- a/pkgs/by-name/be/beatsabermodmanager/package.nix +++ b/pkgs/by-name/be/beatsabermodmanager/package.nix @@ -20,10 +20,7 @@ buildDotnetModule rec { fetchSubmodules = true; # It vendors BSIPA-Linux }; - dotnet-sdk = with dotnetCorePackages; combinePackages [ - sdk_7_0 - sdk_6_0 - ]; + dotnet-sdk = dotnetCorePackages.sdk_7_0; dotnet-runtime = dotnetCorePackages.runtime_7_0; diff --git a/pkgs/by-name/fs/fsautocomplete/package.nix b/pkgs/by-name/fs/fsautocomplete/package.nix index b3560f9ab7ed2..031567b5a87f3 100644 --- a/pkgs/by-name/fs/fsautocomplete/package.nix +++ b/pkgs/by-name/fs/fsautocomplete/package.nix @@ -36,11 +36,10 @@ buildDotnetModule (finalAttrs: rec { dotnet-sdk = with dotnetCorePackages; - combinePackages [ - sdk_6_0 - sdk_7_0 - sdk_8_0 - ]; + sdk_8_0 + // { + inherit (sdk_6_0) packages targetPackages; + }; dotnet-runtime = dotnetCorePackages.sdk_8_0; projectFile = "src/FsAutoComplete/FsAutoComplete.fsproj"; diff --git a/pkgs/by-name/ga/garnet/package.nix b/pkgs/by-name/ga/garnet/package.nix index e1850133807c3..de661cd58ba63 100644 --- a/pkgs/by-name/ga/garnet/package.nix +++ b/pkgs/by-name/ga/garnet/package.nix @@ -20,12 +20,7 @@ buildDotnetModule rec { projectFile = "main/GarnetServer/GarnetServer.csproj"; nugetDeps = ./deps.nix; - dotnet-sdk = - with dotnetCorePackages; - combinePackages [ - sdk_6_0 - sdk_8_0 - ]; + dotnet-sdk = dotnetCorePackages.sdk_8_0; dotnet-runtime = dotnetCorePackages.runtime_8_0; dotnetBuildFlags = [ diff --git a/pkgs/by-name/na/naps2/package.nix b/pkgs/by-name/na/naps2/package.nix index 93161f889efd8..ad5241cf2ee8e 100644 --- a/pkgs/by-name/na/naps2/package.nix +++ b/pkgs/by-name/na/naps2/package.nix @@ -26,7 +26,19 @@ buildDotnetModule rec { executables = [ "naps2" ]; - dotnet-sdk = with dotnetCorePackages; combinePackages [ sdk_6_0 sdk_8_0 ]; + dotnet-sdk = + with dotnetCorePackages; + sdk_8_0 + // { + inherit + (combinePackages [ + sdk_8_0 + sdk_6_0 + ]) + packages + targetPackages + ; + }; dotnet-runtime = dotnetCorePackages.runtime_8_0; selfContainedBuild = true; runtimeDeps = [ diff --git a/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix b/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix index 9ad8c3b335f60..c5b1da7f57c88 100644 --- a/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix +++ b/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix @@ -55,8 +55,7 @@ buildDotnetModule rec { updateScript = ./update.sh; }; - # SDK 6.0 required for Robust.LoaderApi - dotnet-sdk = with dotnetCorePackages; combinePackages [ sdk_8_0 sdk_6_0 ]; + dotnet-sdk = dotnetCorePackages.sdk_8_0; dotnet-runtime = dotnetCorePackages.runtime_8_0; dotnetFlags = [