Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-sdk_6.0: 6.0.403 -> 6.0.405 #206767

Merged
merged 3 commits into from
Jan 11, 2023
Merged

dotnet-sdk_6.0: 6.0.403 -> 6.0.405 #206767

merged 3 commits into from
Jan 11, 2023

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Dec 18, 2022 •
edited
Loading

Description of changes

version update via update.sh

Contains fixes for:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1576

@JamieMagee JamieMagee added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 3, 2023
@JamieMagee
Copy link
Member Author

JamieMagee commented Jan 3, 2023 •
edited
Loading

This update contains a fix for CVE-2022-41089. See https://github.com/dotnet/core/blob/main/release-notes/6.0/6.0.12/6.0.12.md

@risicle
Copy link
Contributor

risicle commented Jan 6, 2023

@ofborg build jackett

@risicle
Copy link
Contributor

risicle commented Jan 6, 2023

@ofborg build roslyn

@risicle
Copy link
Contributor

risicle commented Jan 6, 2023

@ofborg build github-runner

@risicle
Copy link
Contributor

risicle commented Jan 6, 2023

At least jackett and roslyn appear to be broken by this on multiple platforms. Please nixpkgs-review your pull requests.

@JamieMagee
Copy link
Member Author

Result of nixpkgs-review pr 206767 run on x86_64-linux 1

1 package blacklisted:
  • tests.writers
3 packages failed to build:
  • jackett
  • msbuild
  • roslyn
28 packages built:
  • ArchiSteamFarm
  • boogie (dotnetPackages.Boogie)
  • btcpayserver
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnet-aspnetcore_6 ,dotnetCorePackages.aspnetcore_6_0)
  • dotnet-runtime (dotnet-runtime_6 ,dotnetCorePackages.runtime_6_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • formula
  • galaxy-buds-client
  • github-runner
  • jellyfin
  • jetbrains.rider
  • lidarr
  • nbxplorer
  • netcoredbg
  • nuget-to-nix
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pinta
  • pre-commit
  • prowlarr
  • ps3-disc-dumper
  • radarr
  • scarab
  • wasabiwallet
  • xivlauncher

@JamieMagee
Copy link
Member Author

Jackett test failure is due to a test that expects a specific year. The test pass when I created the PR in 2022, but fails in 2023 🤦

@ofborg ofborg bot requested review from edwtjo, purcell and nyanloutre January 7, 2023 06:12
@JamieMagee
Copy link
Member Author

JamieMagee commented Jan 7, 2023 •
edited
Loading

roslyn built until #206765 was merged and the specific versions of .NET Core 3.1 that it depended on (should this package specify dotnet-runtime?).

msbuild depends on roslyn.

@JamieMagee
Copy link
Member Author

Result of nixpkgs-review pr 206767 run on x86_64-linux 1

29 packages built:
  • boogie
  • btcpayserver
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-aspnetcore
  • dotnet-runtime
  • dotnet-sdk
  • formula
  • galaxy-buds-client
  • github-runner
  • jackett
  • jellyfin
  • jetbrains.rider
  • lidarr
  • msbuild
  • nbxplorer
  • netcoredbg
  • nuget-to-nix
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pre-commit
  • prowlarr
  • ps3-disc-dumper
  • radarr
  • roslyn
  • scarab
  • wasabiwallet
  • xivlauncher

@JamieMagee JamieMagee requested a review from risicle January 9, 2023 02:06
@JamieMagee
Copy link
Member Author

Updated to 6.0.405 which includes a fix for CVE-2023-21538

@JamieMagee
Copy link
Member Author

Result of nixpkgs-review pr 206767 run on x86_64-linux 1

30 packages built:
  • boogie
  • btcpayserver
  • btcpayserver-altcoins
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-aspnetcore
  • dotnet-runtime
  • dotnet-sdk
  • formula
  • galaxy-buds-client
  • github-runner
  • jackett
  • jellyfin
  • jetbrains.rider
  • lidarr
  • msbuild
  • nbxplorer
  • netcoredbg
  • nuget-to-nix
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pre-commit
  • prowlarr
  • ps3-disc-dumper
  • radarr
  • roslyn
  • scarab
  • wasabiwallet
  • xivlauncher

@JamieMagee JamieMagee changed the title dotnet-sdk_6.0: 6.0.403 -> 6.0.404 dotnet-sdk_6.0: 6.0.403 -> 6.0.405 Jan 11, 2023
@SuperSandro2000 SuperSandro2000 merged commit 1141179 into NixOS:master Jan 11, 2023
@github-actions
Copy link
Contributor

Backport failed for release-22.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.11
git worktree add -d .worktree/backport-206767-to-release-22.11 origin/release-22.11
cd .worktree/backport-206767-to-release-22.11
git checkout -b backport-206767-to-release-22.11
ancref=$(git merge-base 9852294f15c380cd61fd441538982426f8ee8ccc 6cb0f3d70ba06cff5e7f47fd5134b17c89c90291)
git cherry-pick -x $ancref..6cb0f3d70ba06cff5e7f47fd5134b17c89c90291

@JamieMagee JamieMagee deleted the dotnet-6.0 branch January 11, 2023 15:26
@LeSuisse LeSuisse added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 14, 2023
@github-actions
Copy link
Contributor

Backport failed for release-22.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.11
git worktree add -d .worktree/backport-206767-to-release-22.11 origin/release-22.11
cd .worktree/backport-206767-to-release-22.11
git checkout -b backport-206767-to-release-22.11
ancref=$(git merge-base 9852294f15c380cd61fd441538982426f8ee8ccc 6cb0f3d70ba06cff5e7f47fd5134b17c89c90291)
git cherry-pick -x $ancref..6cb0f3d70ba06cff5e7f47fd5134b17c89c90291

@newAM newAM mentioned this pull request Feb 20, 2023
Closed
1 task
@LeSuisse LeSuisse added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Backport failed for release-22.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.11
git worktree add -d .worktree/backport-206767-to-release-22.11 origin/release-22.11
cd .worktree/backport-206767-to-release-22.11
git checkout -b backport-206767-to-release-22.11
ancref=$(git merge-base 9852294f15c380cd61fd441538982426f8ee8ccc 6cb0f3d70ba06cff5e7f47fd5134b17c89c90291)
git cherry-pick -x $ancref..6cb0f3d70ba06cff5e7f47fd5134b17c89c90291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdarocha mdarocha mdarocha approved these changes

@IvarWithoutBones IvarWithoutBones Awaiting requested review from IvarWithoutBones

@edwtjo edwtjo Awaiting requested review from edwtjo

@purcell purcell Awaiting requested review from purcell

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

@risicle risicle Awaiting requested review from risicle

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JamieMagee @nixos-discourse @risicle @mdarocha @LeSuisse @SuperSandro2000