Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aquamarine: 0.4.4 -> 0.4.5 #355598

Closed
wants to merge 1 commit into from
Closed

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Nov 13, 2024

Changes: https://github.com/hyprwm/aquamarine/releases/tag/v0.4.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
Copy link
Contributor Author

trofi commented Nov 13, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 355598


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • hyprlandPlugins.hycov
✅ 27 packages built:
  • aquamarine
  • aquamarine.dev
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hypr-dynamic-cursors
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprfocus
  • hyprlandPlugins.hyprgrass
  • hyprlandPlugins.hyprscroller
  • hyprlandPlugins.hyprspace
  • hyprlandPlugins.hyprsplit
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

@Atemu
Copy link
Member

Atemu commented Nov 13, 2024

This appears to be merely this PR which is some sort of experimental thing, explicitly untested: hyprwm/aquamarine#104

I think we should hold off on that until branch-off.

@ofborg ofborg bot requested review from JohnRTitor and fufexan November 13, 2024 18:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 13, 2024
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd rather merge it after the implementation in Hyprland is merged and present in a Hyprland release.

But let's ask @fufexan anyway

@fufexan
Copy link
Contributor

fufexan commented Nov 13, 2024

Yeah let's wait until that's done, maybe vaxry bumps aquamarine again by then.

@trofi trofi closed this Nov 13, 2024
@trofi trofi deleted the aquamarine-update branch November 13, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants