🤖

Author: BrianHicks

exe/deploy-complexity.rb

@@ -71,7 +71,7 @@ def deploy(base, to, options)
   end
 
 options[:gh_url] ||=
-  "https://github.com/" + `git config --get remote.origin.url`[/:(.+).git/, 1]
+  "https://github.com/#{`git config --get remote.origin.url`[/:(.+).git/, 1]}"
 
 deploys = `git tag -l | grep #{branch}`.split(/\n/).drop(1)
 case action

lib/deploy_complexity/changed_javascript_packages.rb

@@ -12,8 +12,8 @@ def parse_dependencies(file)
       json = JSON.parse(file)
       dependencies = json.fetch("dependencies")
 
-      dependencies.each_with_object({}) do |(dependency, details), collection|
-        collection[dependency] = details.fetch("version")
+      dependencies.transform_values do |details|
+        details.fetch("version")
       end
     end
   end

lib/deploy_complexity/cli_output_formatter.rb

@@ -12,14 +12,13 @@ def format
 
       return output unless added_attachments.any?
 
-      output + "\n\n" +
-        added_attachments.map { |a| format_attachment(a) }.join("\n\n")
+      "#{output}\n\n#{added_attachments.map { |a| format_attachment(a) }.join("\n\n")}"
     end
 
     private
 
     def format_attachment(attachment)
-      attachment.title + "\n" + attachment.text
+      "#{attachment.title}\n#{attachment.text}"
     end
   end
 end

lib/deploy_complexity/deploy.rb

@@ -153,8 +153,7 @@ def pull_requests(merges)
 
     def get_merges(commits)
       merges = commits.grep(/Merges|\#\d+/)
-      merges = merges.select { |m| makes_changes_to(m) }
-      merges
+      merges.select { |m| makes_changes_to(m) }
     end
 
     def get_changed_files(range)
@@ -170,7 +169,7 @@ def makes_changes_to(merge)
     end
 
     def pattern
-      @pattern ||= options[:subdir] ? Regexp.new("^" + @options[:subdir]) : /.*/
+      @pattern ||= options[:subdir] ? Regexp.new("^#{@options[:subdir]}") : /.*/
     end
 
     def subdir

spec/lib/deploy_complexity/checklists_spec.rb

@@ -9,7 +9,7 @@ def diff(path, patch: "")
     double(path: path, patch: patch)
   end
 
-  class TestChecklist < Checklists::Checklist
+  class TestChecklist < Checklists::Checklist # rubocop:disable Lint/ConstantDefinitionInBlock
     def human_name
       "Human Name"
     end
@@ -23,7 +23,7 @@ def relevant_for(files)
     end
   end
 
-  class PatchChecklist < Checklists::Checklist
+  class PatchChecklist < Checklists::Checklist # rubocop:disable Lint/ConstantDefinitionInBlock
     def human_name
       "patches"
     end