fix all the damn lint in my editor

Author: davidnewhall

Diff for: frontend/src/Settings/General.svelte

@@ -8,7 +8,7 @@
   import T, { _ } from "/src/libs/Translate.svelte"
 
   let langHelp = false
-  let langs = undefined
+  let langs: {[key: string]: string;}
   const update = () => Languages().then(v => langs = v)
   update()
 </script>

Diff for: frontend/src/Settings/Index.svelte

@@ -19,7 +19,7 @@
   let confHelp = false
   let confSpin = false
 
-  function createWindowsShortcut(e) {
+  function createWindowsShortcut(e: MouseEvent) {
     e.preventDefault()
     CreateShortcut().then(
       msg => (toast("info", msg)),
@@ -34,9 +34,9 @@
     <Row>
       <p>{$_("main_application_settings")}</p>
       <Form class="Settings">
-        <div on:mouseenter={() => {confSpin=true}} on:mouseleave={() => {confSpin=false}}>
+        <div on:mouseenter={() => {confSpin=true}} on:mouseleave={() => {confSpin=false}} role="link" tabindex="-1">
           <InputGroup>
-            <ConfigInput locked type="text" id="File" placement="bottom" />
+            <ConfigInput locked type="text" id="Unused" placement="bottom" />
             <Button on:click={(e) => {e.preventDefault();confHelp = !confHelp}}>
               <Fa primaryColor="cyan" spin={confSpin} icon="{faQuestion}" />
             </Button>

Diff for: frontend/src/Settings/Logs.svelte

@@ -6,11 +6,12 @@
   import { app, conf } from "/src/libs/config"
   import ConfigInput from "/src/libs/Input.svelte"
   import T, { _ } from "/src/libs/Translate.svelte"
+  import type { SvelteComponent } from "svelte";
 
-  let confPath
+  let confPath: SvelteComponent
   // This func opens a "pick a folder" dialog and populates the Log File Path with the current config file folder.
-  function getLogFolder(event) {
-    event.preventDefault()
+  function getLogFolder(e: MouseEvent) {
+    e.preventDefault()
     PickFolder("").then(path => {if (path != "") confPath.update(path)})
   }
 </script>

Diff for: frontend/src/Starr/Actions/AppProfiles.svelte

@@ -1,6 +1,7 @@
 <script lang="ts">
   export let info
-  export let instance
+  export let instance: Instance
+  import type { Instance } from "/src/libs/config"
   import { Card } from "@sveltestrap/sveltestrap"
   import T, { _ } from "/src/libs/Translate.svelte"
   import { toast } from "/src/libs/funcs"

Diff for: frontend/src/Starr/Actions/BlockLists.svelte

@@ -52,8 +52,8 @@
     cv = $_("configvalues.SeriesTitle")
   }
 
-  function sort(e) {
-    if (e.target.id == sortKey) sortDir = !sortDir
+  function sort(e: any) {
+    if (e.target && e.target.id == sortKey) sortDir = !sortDir
     sortKey = e.target.id
     dispatch("update", true)
   }
@@ -66,18 +66,18 @@
 
     <!-- App Specific -->
     <th>
-      <span class="link" {id} on:keyup={sort} on:click={sort}>{cv}</span>
+      <span class="link" {id} on:keyup={sort} on:click={sort} role="link" tabindex="-1">{cv}</span>
       <Icon name={sortKey==id?caret:""}/>
     </th>
 
     <!-- All Apps -->
     <th class="d-none d-md-table-cell">
-      <span class="link" id="sourceTitle" on:keyup={sort} on:click={sort}>{$_("configvalues.SourceTitle")}</span>
+      <span class="link" id="sourceTitle" on:keyup={sort} on:click={sort} role="link" tabindex="-2">{$_("configvalues.SourceTitle")}</span>
       <Icon name={sortKey=="sourceTitle"?caret:""}/>
     </th>
     <th>{$_("words.Quality")}</th>
       <th>
-        <span class="link" id="date" on:keyup={sort} on:click={sort}>{$_("words.Date")}</span>
+        <span class="link" id="date" on:keyup={sort} on:click={sort} role="link" tabindex="-3">{$_("words.Date")}</span>
         <Icon name={sortKey=="date"?caret:""}/>
       </th>
     </tr>

Diff for: frontend/src/Starr/Actions/CustomFilters.svelte

@@ -1,7 +1,8 @@
 <script lang="ts">
   export let info
-  export let instance
+  export let instance: Instance
 
+  import type { Instance } from "/src/libs/config"
   import { Card } from "@sveltestrap/sveltestrap"
   import T, { _ } from "/src/libs/Translate.svelte"
   import { toast } from "/src/libs/funcs"

Diff for: frontend/src/Starr/Actions/ImportLists.svelte

@@ -207,10 +207,10 @@
 
 <Card class="p-1" color="secondary">
   <!-- <Tooltip target="exclusions">Close this card to reset the Exclusions form.</Tooltip> -->
-  <h5 style="cursor:pointer" on:keyup={()=>{exclusionsOpen=!exclusionsOpen}} on:click={()=>{exclusionsOpen=!exclusionsOpen}}>
+  <h5><span on:keyup={()=>{exclusionsOpen=!exclusionsOpen}} on:click={()=>{exclusionsOpen=!exclusionsOpen}} role="link" tabindex="-1">
     <span id="exclusions">Import List Exclusions</span>
     <Icon class="text-info" name={exclusionsOpen?"caret-down-fill":"caret-up"}/>
-  </h5>
+  </span></h5>
   <Collapse isOpen={exclusions != undefined && exclusionsOpen}>
     <Exclusions bind:updating info={exclusions} {instance}/>
   </Collapse>

Diff for: frontend/src/Starr/Actions/QualityProfiles.svelte

@@ -1,9 +1,10 @@
 <script lang="ts">
   export let tab: Tab
-  export let info
-  export let instance
+  export let info: any
+  export let instance: Instance
   export let updating: boolean
 
+  import type { Instance } from "/src/libs/config"
   import type { Tab } from "./fragments/tabs.svelte"
   import { _ } from "/src/libs/Translate.svelte"
   import Footer from "./fragments/footer.svelte"

Diff for: frontend/src/Starr/Actions/action.svelte

@@ -25,7 +25,7 @@
   import { faCaretDown, faCaretUp } from "@fortawesome/free-solid-svg-icons"
 
   let rawOpen = false
-  let info = undefined
+  let info: any = undefined
   let prevTab = tab
   let prevURL = ""
   // These are only used for pageable content.
@@ -38,24 +38,24 @@
   // update info when tab or instance changes.
   $: if (tab&&instance&&!hidden) update({})
 
-  async function update(e) {
+  async function update(e: any) {
     if (prevURL === instance.URL && prevTab === tab && info && !e.detail) return
 
     prevTab = tab
     updating = true
     info = undefined
 
     if (instance.URL=="") return
-    if (tab.page) {
-      await tab.data(instance, pageSize, page, sortKey, sortDir?"ascending":"descending").then(
+    if (tab.pageData) {
+      await tab.pageData(instance, pageSize, page, sortKey, sortDir?"ascending":"descending").then(
         rep => {
           info = rep
           prevURL = instance.URL
           pages = Math.ceil(info.totalRecords / info.pageSize)
         },
         err => toast("error", err),
       )
-    } else {
+    } else if (tab.data) {
       await tab.data(instance).then(
         rep => { info = rep; prevURL = instance.URL },
         err => toast("error", err),
@@ -77,7 +77,7 @@
     {#if info}
     <div id="container" class={$conf.Dark?"dark-mode":""}>
       <!-- We have all the pieces we need. Load the selected tab's component. -->
-      {#if !tab.page}
+      {#if !tab.pageData}
         <svelte:component this={tab.component} {instance} {tab} bind:info bind:updating />
       {:else}<!-- tab is pagable-->
         <svelte:component {instance} {tab}

Diff for: frontend/src/Starr/Actions/blockListsRow.svelte

@@ -9,17 +9,17 @@
   import { _, date } from "/src/libs/Translate.svelte"
   import { conf } from "/src/libs/config"
 
-  function poster(data): string {
+  function poster(data: any): string {
     let url = "."
-    data.forEach(item => {
+    data.forEach((item: any) => {
       if (item.coverType == "poster") url = item.url?item.url:item.remoteUrl
     })
     return url
   }
 
-  function getName(id, list) {
+  function getName(id: any, list: any) {
     let name = id
-    list.forEach((item) => {
+    list.forEach((item: any) => {
       if (item.id == id) {
         name = item.name
         return name

Diff for: frontend/src/Starr/Actions/fragments/dropdown.svelte

@@ -13,11 +13,11 @@
   import { onOnce } from "/src/libs/funcs"
 
   $: title = name ? $_(name) : $_(`instances.${field}Title`)
-  let dropdown
+  let dropdown: HTMLElement
 
-  function toggleAll(key, on) {
+  function toggleAll(key: string, on: boolean) {
     var idx = 0.15 // initial delay to click.
-    form.forEach((_, i) => { // progressively faster.
+    form.forEach((_: any, i: number) => { // progressively faster.
       onOnce(() => {form[i][key] = on}, idx += 0.08 - (idx/14))
     })
   }
@@ -29,7 +29,7 @@
 <Dropdown size="sm">
   <DropdownToggle tag="span" class="link">
     <span bind:this={dropdown}>
-      {title.match(/\b(\w)/g).join('').substring(0,2)} <Fa primaryColor="darkCyan" icon={faCircleInfo}/>
+      {title.match(/\b(\w)/g)?.join('').substring(0,2)} <Fa primaryColor="darkCyan" icon={faCircleInfo}/>
     </span>
   </DropdownToggle>
   <DropdownMenu>

Diff for: frontend/src/Starr/Actions/fragments/fieldInput.svelte

@@ -8,7 +8,7 @@
   import { _ } from "/src/libs/Translate.svelte"
   import { Input, InputGroup, InputGroupText, Tooltip } from "@sveltestrap/sveltestrap"
 
-  let input
+  let input: HTMLElement
   // changed.
   $: invalid = info[idx].fields[itemIdx].value != form[idx].fields[itemIdx].value
 </script>

Diff for: frontend/src/Starr/Actions/fragments/footer.svelte

@@ -22,9 +22,9 @@
   let goodMsg = ""
   $: selectedCount = count(selected)        // How many items are selected.
   $: unSaved = JSON.stringify(form) !== str // True when something changed.
-  let button: any
+  let button: HTMLElement
 
-  function showMsg(idx: number, msg: string, data) {
+  function showMsg(idx: number, msg: string, data: any) {
     goodMsg += `<li>${$_("instances.SuccessMsg", {values:{"msg": msg}})}</li>`
     let kind = "update"
 
@@ -54,13 +54,13 @@
       if (JSON.stringify(form[idx]) == JSON.stringify(info[idx])) continue // not changed
       if (noForce) {
         await update[tab.id][instance.App](instance, form[idx]).then(
-          (resp) => showMsg(idx, resp.Msg, resp.Data),
-          (err) => showError(idx, err)
+          (resp: any) => showMsg(idx, resp.Msg, resp.Data),
+          (err: string) => showError(idx, err)
         )
       } else {
         await update[tab.id][instance.App](instance, force, form[idx]).then(
-          (resp) => showMsg(idx, resp.Msg, resp.Data),
-          (err) => showError(idx, err)
+          (resp: any) => showMsg(idx, resp.Msg, resp.Data),
+          (err: string) => showError(idx, err)
         )
       }
     }
@@ -79,8 +79,8 @@
     for (var idx = info.length-1; idx >= 0; idx--) {
       if (!selected[info[idx].id]) continue // Not selected.
       await remove[tab.id][instance.App](instance, info[idx].id).then(
-        (msg) => showMsg(idx, msg, false),
-        (err) => showError(idx, err)
+        (msg: string) => showMsg(idx, msg, false),
+        (err: string) => showError(idx, err)
       )
     }
 
@@ -96,8 +96,8 @@
     for (var idx = info.length-1; idx >= 0; idx--) {
       if (!selected[info[idx].id]) continue // Not selected.
       await test[tab.id][instance.App](instance, info[idx]).then(
-        (msg) => {goodMsg += `<li>${$_("instances.SuccessMsg", {values:{"msg": msg}})}</li>`},
-        (err) => {badMsg += `<li>${$_("instances.ErrorMsg", {values:{"msg": err}})}</li>`},
+        (msg: string) => {goodMsg += `<li>${$_("instances.SuccessMsg", {values:{"msg": msg}})}</li>`},
+        (err: string) => {badMsg += `<li>${$_("instances.ErrorMsg", {values:{"msg": err}})}</li>`},
       )
     }
 

Diff for: frontend/src/Starr/Actions/fragments/modalInput.svelte

@@ -19,14 +19,14 @@
   $: tooltip = desc ? $_(desc, vals) : $_(`instances.${field}Desc`, vals)
   $: title = name ? $_(name) : $_(`instances.${field}Title`)
 
-  function applyToAll(field, idx) {
+  function applyToAll(field: string, idx: number) {
     for (const listID in form) {
       form[listID][field] = form[idx][field]
     }
   }
 
-  let input
-  let button
+  let input: HTMLElement
+  let button: HTMLElement
 </script>
 
 {#if form[idx][field] !== undefined}

Diff for: frontend/src/Starr/Actions/fragments/paginate.svelte

@@ -46,9 +46,10 @@
     return endPage-5 > 0 ? endPage-5 : 1
   }
 
-  function setSize(e) {
+  function setSize(e: MouseEvent) {
     e.preventDefault()
-    const newSize = parseInt(e.target.value)
+    const target = e.target as HTMLSelectElement;
+    const newSize = parseInt(target.value)
     if (newSize == pageSize) return
     page = 1 // need to start the page over too.
     pageSize = newSize

Diff for: frontend/src/Starr/Actions/fragments/selectAllHeader.svelte

@@ -25,7 +25,7 @@
 <th>
   <span>
     <Icon class="small text-{color}" name={icon}/>
-    <span class={updating?"":"link"} on:keypress={selectAll} on:click={selectAll}>
+    <span class={updating?"":"link"} on:keypress={selectAll} on:click={selectAll} role="link" tabindex="-1">
       {$_("words.All")}
     </span>
   </span>

Diff for: frontend/src/Starr/Actions/fragments/tableInput.svelte

@@ -29,7 +29,7 @@
       {#if type == "switch"}
         <Input disabled={updating} type="switch" bind:checked={form[idx][field]} />
       {:else if type == "text"}
-      <div class="link"
+      <div class="link" role="link" tabindex="-1"
         on:focusout={() => edit(false)}
         on:focusin={() => edit(true)}
         on:keyup={() => edit(true)}

Diff for: frontend/src/Starr/Actions/fragments/tabs.svelte

@@ -19,21 +19,21 @@
   } from "/wailsjs/go/starrs/Starrs"
 
   export type Tab = {
-    data: (instance: any, pageSize?: number, page?: number, sortKey?: string, sortDir?: string) => Promise<any>
+    data?: (instance: any) => Promise<any>
+    pageData?: (instance: any, pageSize: number, page: number, sortKey: string, sortDir: string) => Promise<any>
     id: string
     component?: ComponentType
-    page?: boolean
   }
 
   // All apps have these tabs.
   const commonTabs: Tab[] = [
     { data: Indexers, id: "Indexers", component: indexers },
-    { data: Downloaders, id: "DownloadClients", component: downloadClients },
+    { data: Downloaders, id: "DownloadClients", component: downloadClients }
   ]
 
   // Everything but Prowlarr.
   const starrTabs = commonTabs.concat([
-    { data: BlockList, id: "BlockLists", component: blockList, page: true },
+    { pageData: BlockList, id: "BlockLists", component: blockList },
     { data: QualityProfiles, id: "QualityProfiles", component: qualityProfiles },
     { data: ImportLists, id: "ImportLists", component: importLists },
   ])

Diff for: frontend/src/Starr/Actions/methods.ts

@@ -51,7 +51,7 @@ import {
   TestWhisparrImportList,
 } from "/wailsjs/go/starrs/Starrs"
 
-export function fixFieldValues(info) {
+export function fixFieldValues(info: {[key: string]: any}): string {
   info.forEach((item, idx) => {
     if (!item.fields) return
     item.fields.forEach((field, itemIdx) => {
@@ -62,7 +62,7 @@ export function fixFieldValues(info) {
   return JSON.stringify(info)
 }
 
-export const remove = {
+export const remove: {[key: string]: {[key: string]: (...args: any[]) => Promise<any>;}} = {
   "BlockLists": {
     "Lidarr":   DeleteBlockList,
     "Prowlarr": DeleteBlockList,
@@ -112,7 +112,7 @@ export const remove = {
   }
 }
 
-export const update = {
+export const update: {[key: string]: {[key: string]: (...args: any[]) => Promise<any>;}} = {
   "DownloadClients": {
     "Lidarr":   UpdateLidarrDownloadClient,
     "Prowlarr": UpdateProwlarrDownloadClient,
@@ -152,7 +152,7 @@ export const update = {
   },
 }
 
-export const test = {
+export const test:  {[key: string]: {[key: string]: (...args: any[]) => Promise<string>;}} = {
   "DownloadClients": {
     "Lidarr":   TestLidarrDownloadClient,
     "Prowlarr": TestProwlarrDownloadClient,