Fix issue with null system prompt after #104 (#107)

SumanthRH · web-flow · commit 5fb4f2b5b171 · 2025-04-17T16:17:42.000-07:00
# What does this PR do? Fixes an issue with null system prompt introduced in #104
diff --git a/skythought/evals/inference_and_check.py b/skythought/evals/inference_and_check.py
@@ -237,7 +237,7 @@ def generate_responses_for_dataset(
     # Prepare conversations
     conversations = handler.make_conversations(
         remaining_data,
-        str(model_config.system_prompt),
+        str(model_config.system_prompt) if model_config.system_prompt else None,
         model_config.user_template,
         model_config.assistant_prefill,
     )

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ def generate_responses_for_dataset(`
`237`	`237`	`# Prepare conversations`
`238`	`238`	`conversations = handler.make_conversations(`
`239`	`239`	`remaining_data,`
`240`		`- str(model_config.system_prompt),`
	`240`	`+ str(model_config.system_prompt) if model_config.system_prompt else None,`
`241`	`241`	`model_config.user_template,`
`242`	`242`	`model_config.assistant_prefill,`
`243`	`243`	`)`