Skip to content

Commit 6c4541a

Browse files
author
Jens Plüddemann
committed
removed unused filter, fixed login, name and email being arrays and thus crashing the script
1 parent c7f9f9b commit 6c4541a

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

script/ldap.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,6 @@ def fetch_users_of_group(group_name):
7373

7474
for group in groups:
7575
for member_dn in group["attributes"][configuration.LDAP_MEMBER_ATTRIBUTE]:
76-
if configuration.LDAP_USER_SEARCH_FILTER:
77-
user_query_filter = configuration.LDAP_USER_SEARCH_FILTER
78-
else:
79-
user_query_filter = "(objectClass=*)"
80-
8176
user = get_member(member_dn)
8277

8378
if not user:
@@ -96,8 +91,7 @@ def fetch_users_of_group(group_name):
9691

9792
# Filter out any duplicates from the result array
9893
# Also we remove the object class key
99-
distinct_results = list({u["login"]: {i:u[i] for i in u if i != "objectClass"} for u in result}.values())
100-
return distinct_results
94+
return list({u["login"]: {i:u[i] for i in u if i != "objectClass"} for u in result}.values())
10195

10296

10397
def get_users_of_group(group):
@@ -167,8 +161,8 @@ def fetch_member(member_dn):
167161
connection.unbind()
168162

169163
return {
170-
"login": login,
171-
"name": name,
172-
"email": mail,
164+
"login": login[0] if isinstance(login, list) else login,
165+
"name": name[0] if isinstance(name, list) else name,
166+
"email": mail[0] if isinstance(mail, list) else mail,
173167
"objectClass": objectClass
174168
}

0 commit comments

Comments
 (0)