clean up deprecation and enable -Xlint:deprecation

Author: Librazy

Diff for: build.gradle

@@ -38,12 +38,11 @@ repositories {
 dependencies {
     compile 'org.spigotmc:spigot-api:1.11.2-R0.1-SNAPSHOT'
     compile 'net.milkbowl.vault:VaultAPI:1.6'
-    compile 'org.librazy:NyaaUtilsLangChecker:1.0-SNAPSHOT'
     processor 'org.librazy:NyaaUtilsLangChecker:1.0-SNAPSHOT'
 }
 
 compileJava {
-    options.compilerArgs += ["-Xplugin:NyaaUtilsLangAnnotationProcessor"]
+    options.compilerArgs += ["-Xplugin:NyaaUtilsLangAnnotationProcessor", "-Xlint:deprecation"]
 }
 
 publishing {

Diff for: src/main/java/cat/nyaa/nyaacore/CommandReceiver.java

@@ -22,6 +22,7 @@
 import java.text.DecimalFormat;
 import java.util.*;
 
+@SuppressWarnings("unused")
 public abstract class CommandReceiver<T extends JavaPlugin> implements CommandExecutor, TabCompleter {
     //==== Error Definitions ====//
     private static class NotPlayerException extends RuntimeException {
@@ -111,7 +112,7 @@ public CommandReceiver(T plugin, LanguageRepository i18n) {
             if (!(params.length == 2 &&
                     params[0] == CommandSender.class &&
                     params[1] == Arguments.class)) {
-                plugin.getLogger().warning(i18n.get("internal.error.bad_subcommand", m.toString()));
+                plugin.getLogger().warning(i18n.getFormatted("internal.error.bad_subcommand", m.toString()));
             } else {
                 m.setAccessible(true);
                 subCommands.put(anno.value().toLowerCase(), m);
@@ -135,12 +136,12 @@ public CommandReceiver(T plugin, LanguageRepository i18n) {
                         f.set(this, obj);
                     }
                 } catch (ReflectiveOperationException ex) {
-                    plugin.getLogger().warning(i18n.get("internal.error.bad_subcommand", f.toString()));
+                    plugin.getLogger().warning(i18n.getFormatted("internal.error.bad_subcommand", f.toString()));
                     obj = null;
                     ex.printStackTrace();
                 }
             } else {
-                plugin.getLogger().warning(i18n.get("internal.error.bad_subcommand", f.toString()));
+                plugin.getLogger().warning(i18n.getFormatted("internal.error.bad_subcommand", f.toString()));
             }
         }
     }
@@ -261,9 +262,9 @@ private String getHelpContent(@LangKey(type = LangKeyType.SUFFIX, skipCheck = tr
         }
         key += "." + type;
         if (i18n.hasKey(key)) {
-            return i18n.get(key);
+            return i18n.getFormatted(key);
         } else {
-            return i18n.get("manual.no_" + type);
+            return i18n.getFormatted("manual.no_" + type);
         }
     }
 
@@ -289,7 +290,7 @@ public static Player asPlayer(CommandSender target) {
     }
 
     public void msg(CommandSender target, @LangKey String template, Object... args) {
-        target.sendMessage(i18n.get(template, args));
+        target.sendMessage(i18n.getFormatted(template, args));
     }
 
     public static ItemStack getItemInHand(CommandSender se) {
@@ -322,6 +323,7 @@ public static ItemStack getItemInOffHand(CommandSender se) {
         }
     }
 
+    @SuppressWarnings("unused")
     public static class Arguments {
 
         private List<String> parsedArguments = new ArrayList<>();

Diff for: src/main/java/cat/nyaa/nyaacore/LanguageRepository.java

@@ -152,7 +152,7 @@ public void load() {
             plugin.getLogger().warning("Cannot save language file: " + codeName + ".yml");
         }
 
-        plugin.getLogger().info(get("internal.info.using_language", codeName));
+        plugin.getLogger().info(getFormatted("internal.info.using_language", codeName));
     }
 
     /**

Diff for: src/main/java/cat/nyaa/nyaacore/Message.java

@@ -41,7 +41,7 @@ public Message append(String text) {
     }
 
     public Message appendFormat(LanguageRepository i18n, @LangKey String template, Object... obj) {
-        return append(i18n.get(template, obj));
+        return append(i18n.getFormatted(template, obj));
     }
 
     public Message append(ItemStack item) {

Diff for: src/main/java/cat/nyaa/nyaacore/internationalization/I18nEntity.java

@@ -148,6 +148,7 @@ public static String getSpawnEggName(ItemStack egg, String locale) {
      * @throws InvocationTargetException when either method throws an exception.
      * @throws IllegalAccessException    when does not have access to these methods.
      */
+    @SuppressWarnings("deprecation")
     public static EntityType getEntityType(ItemStack egg) throws ClassNotFoundException, NoSuchMethodException, InvocationTargetException, IllegalAccessException {
         Object nmsStack = Class.forName("org.bukkit.craftbukkit." + Bukkit.getServer().getClass().getPackage().getName().replace(".", ",").split(",")[3] + "." + "inventory.CraftItemStack").getMethod("asNMSCopy", ItemStack.class).invoke(null, egg);
         Object tag = nmsStack.getClass().getMethod("getTag").invoke(nmsStack);