Skip to content
This repository was archived by the owner on Mar 8, 2022. It is now read-only.

Better per-module enable/disable #33

Open
RecursiveG opened this issue Nov 23, 2017 · 4 comments
Open

Better per-module enable/disable #33

RecursiveG opened this issue Nov 23, 2017 · 4 comments
Milestone

Comments

@RecursiveG
Copy link
Member

Command changes if needed.
Configure files change if needed.
Code revision.

Related: #32

@RecursiveG RecursiveG added this to the NyaaUtils 5.0 milestone Nov 23, 2017
@Librazy
Copy link
Member

Librazy commented Nov 23, 2017

Can we seprate different modules to different jars?

@RecursiveG
Copy link
Member Author

Generally, no.
Because NyaaUtils is designed to be a single "big" plugin containing all tiny utils.

@RecursiveG
Copy link
Member Author

But since we've isolated NyaaCore, having mutiple jars may be acceptable.
@phoenixlzx

@phoenixlzx
Copy link
Contributor

IMO it's better to keep a single jar, or the plugin lost its original advantage. Just add a global on/off switch for each module/function in the main configuration file is okay.

NyaaCore is created for reduce code duplication and provide a single infrastructure for extra functions, which is not the actual logic implementations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants