Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract report showing last line in black when used external_layout_boxed #1176

Closed
arielbarreiros96 opened this issue Jan 9, 2025 · 2 comments · Fixed by #1181
Closed
Labels

Comments

@arielbarreiros96
Copy link
Contributor

arielbarreiros96 commented Jan 9, 2025

Module

Recurring - Contracts Management (contract)

Describe the bug

(Cosmetic Issue on report) Contract report showing last line in black background color when used external_layout_boxed in all tables, not only on totals. Also totals are shown in black no matter the company color.
image

To Reproduce

Affected versions:
Confirmed on 16.0 and 17.0, presumably the ones before as well.

Steps to reproduce the behavior:

  1. Install the contract module
  2. On general settings set the external layout to external_layout_boxed
  3. Create a contract (customer or supplier)
  4. Print the contract report

Expected behavior
The recurring item lines should be consistent with the rest of reports on the system for this layout (white background, totals in a different color set by company), and with the other layouts for this same report (these don't show this bottom line in a different way)

@arielbarreiros96
Copy link
Contributor Author

Corrections for 16.0 are compatible with 17.0, once the PR #1178 gets merged, the commit there fixing the report can be cherry-picked from 17.0

@arielbarreiros96
Copy link
Contributor Author

Once PR #1181 gets merged, this issue can be closed

@pedrobaeza pedrobaeza linked a pull request Jan 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant