Skip to content

Commit 37aaef8

Browse files
committed
Evict cache when role permissions are updated.
Increased size of small-heap configuration.
1 parent a239706 commit 37aaef8

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/main/java/org/ohdsi/webapi/shiro/PermissionManager.java

+7
Original file line numberDiff line numberDiff line change
@@ -294,13 +294,15 @@ public Set<PermissionEntity> getRolePermissions(Long roleId) {
294294
return permissions;
295295
}
296296

297+
@CacheEvict(cacheNames = CachingSetup.AUTH_INFO_CACHE, allEntries = true)
297298
public void addPermission(Long roleId, Long permissionId) {
298299
PermissionEntity permission = this.getPermissionById(permissionId);
299300
RoleEntity role = this.getRoleById(roleId);
300301

301302
this.addPermission(role, permission, null);
302303
}
303304

305+
@CacheEvict(cacheNames = CachingSetup.AUTH_INFO_CACHE, allEntries = true)
304306
public void addPermission(RoleEntity role, PermissionEntity permission) {
305307
this.addPermission(role, permission, null);
306308
}
@@ -318,13 +320,15 @@ public Set<UserEntity> getRoleUsers(Long roleId) {
318320
return users;
319321
}
320322

323+
@CacheEvict(cacheNames = CachingSetup.AUTH_INFO_CACHE, allEntries = true)
321324
public void addUser(Long userId, Long roleId) {
322325
UserEntity user = this.getUserById(userId);
323326
RoleEntity role = this.getRoleById(roleId);
324327

325328
this.addUser(user, role, UserOrigin.SYSTEM, null);
326329
}
327330

331+
@CacheEvict(cacheNames = CachingSetup.AUTH_INFO_CACHE, allEntries = true)
328332
public void removeUser(Long userId, Long roleId) {
329333
UserRoleEntity userRole = this.userRoleRepository.findByUserIdAndRoleId(userId, roleId);
330334
if (userRole != null)
@@ -553,6 +557,7 @@ public RoleEntity updateRole(RoleEntity roleEntity) {
553557
return this.roleRepository.save(roleEntity);
554558
}
555559

560+
@CacheEvict(cacheNames = CachingSetup.AUTH_INFO_CACHE, allEntries = true)
556561
public void addPermissionsFromTemplate(RoleEntity roleEntity, Map<String, String> template, String value) {
557562
for (Map.Entry<String, String> entry : template.entrySet()) {
558563
String permission = String.format(entry.getKey(), value);
@@ -562,11 +567,13 @@ public void addPermissionsFromTemplate(RoleEntity roleEntity, Map<String, String
562567
}
563568
}
564569

570+
@CacheEvict(cacheNames = CachingSetup.AUTH_INFO_CACHE, allEntries = true)
565571
public void addPermissionsFromTemplate(Map<String, String> template, String value) {
566572
RoleEntity currentUserPersonalRole = getCurrentUserPersonalRole();
567573
addPermissionsFromTemplate(currentUserPersonalRole, template, value);
568574
}
569575

576+
@CacheEvict(cacheNames = CachingSetup.AUTH_INFO_CACHE, allEntries = true)
570577
public void removePermissionsFromTemplate(Map<String, String> template, String value) {
571578
for (Map.Entry<String, String> entry : template.entrySet()) {
572579
String permission = String.format(entry.getKey(), value);

src/main/resources/appCache.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@
1515
</service>
1616
<cache-template name="small-heap">
1717
<resources>
18-
<heap unit="entries">10</heap>
18+
<heap unit="entries">50</heap>
1919
</resources>
2020
</cache-template>
2121
<cache-template name="medium-heap">
2222
<resources>
23-
<heap unit="entries">100</heap>
23+
<heap unit="entries">500</heap>
2424
</resources>
2525
</cache-template>
2626
<cache-template name="medium-offheap">
2727
<resources>
28-
<heap unit="entries">100</heap>
28+
<heap unit="entries">500</heap>
2929
<offheap unit="MB">10</offheap> <!-- unit of measure is case sensitive! -->
3030
</resources>
3131
</cache-template>

0 commit comments

Comments
 (0)