Skip to content

Commit 614ff5b

Browse files
oleg-odysseusalex-odysseus
authored andcommitted
[ATL-54] Fixed issue where the behavior of the demographics checkbox was inconsistent
# Conflicts: # src/main/java/org/ohdsi/webapi/service/CohortGenerationService.java
1 parent a27e6f0 commit 614ff5b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/java/org/ohdsi/webapi/cohortdefinition/GenerationJobExecutionListener.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@ public void afterJob(JobExecution je) {
8888
CohortGenerationInfo info = findBySourceId(df, sourceId);
8989
setExecutionDurationIfPossible(je, info);
9090
info.setStatus(GenerationStatus.COMPLETE);
91-
info.setCcGenerateId(je.getId());
92-
info.setIsChooseDemographic(info.getCcGenerateId() != null);
91+
info.setCcGenerateId(je.getId());
9392

9493
if (je.getStatus() == BatchStatus.FAILED || je.getStatus() == BatchStatus.STOPPED) {
9594
info.setIsValid(false);

src/main/java/org/ohdsi/webapi/service/CohortGenerationService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ public JobExecutionResource generateCohortViaJob(UserEntity userEntity, CohortDe
103103
.orElse(new CohortGenerationInfo(cohortDefinition, source.getSourceId()));
104104

105105
info.setCreatedBy(userEntity);
106+
info.setIsChooseDemographic(demographicStat);
106107

107108
cohortDefinition.getGenerationInfoList().add(info);
108109

@@ -218,7 +219,7 @@ private JobExecutionResource runGenerateCohortJob(CohortDefinition cohortDefinit
218219
Boolean demographic) {
219220
final JobParametersBuilder jobParametersBuilder = getJobParametersBuilder(source, cohortDefinition);
220221

221-
if (demographic != null && demographic.booleanValue()) {
222+
if (demographic != null && demographic) {
222223
jobParametersBuilder.addString(DEMOGRAPHIC_STATS, Boolean.TRUE.toString());
223224
Job job = buildJobForCohortGenerationWithDemographic(cohortDefinition, source, jobParametersBuilder);
224225
return jobService.runJob(job, jobParametersBuilder.toJobParameters()); } else {

0 commit comments

Comments
 (0)