From 7b5fa5c022aaa27c60cbbaefc94012592d01bd10 Mon Sep 17 00:00:00 2001 From: greshje <36824929+greshje@users.noreply.github.com> Date: Mon, 16 Sep 2024 08:31:04 -0400 Subject: [PATCH 1/2] Fix for compile error seen for Eclipse (issue 2390) (#2395) --- mvn | 0 .../AbstractForEachValidatorBuilder.java | 29 +++++++++++++++++-- .../check/builder/ValidatorGroupBuilder.java | 26 +++++++++++++++-- 3 files changed, 51 insertions(+), 4 deletions(-) create mode 100644 mvn diff --git a/mvn b/mvn new file mode 100644 index 0000000000..e69de29bb2 diff --git a/src/main/java/org/ohdsi/webapi/check/builder/AbstractForEachValidatorBuilder.java b/src/main/java/org/ohdsi/webapi/check/builder/AbstractForEachValidatorBuilder.java index ea93a7c0c2..b19b3ce3b3 100644 --- a/src/main/java/org/ohdsi/webapi/check/builder/AbstractForEachValidatorBuilder.java +++ b/src/main/java/org/ohdsi/webapi/check/builder/AbstractForEachValidatorBuilder.java @@ -41,9 +41,34 @@ public final AbstractForEachValidatorBuilder groups(ValidatorGroupBuilder< } protected List> initGroups() { - return initAndBuildList(this.validatorGroupBuilders); + return initAndBuildGroupList(this.validatorGroupBuilders); } + // Note: exact same functionality as initAndBuildList, just needed a different call signature. + // This method was added to enable development using Eclipse + private List> initAndBuildGroupList(List> builders) { + + builders.forEach(builder -> { + if (Objects.isNull(builder.getBasePath())) { + builder.basePath(createChildPath()); + } + if (Objects.isNull(builder.getErrorMessage())) { + builder.errorMessage(this.errorMessage); + } + if (Objects.isNull(builder.getSeverity())) { + builder.severity(this.severity); + } + if (Objects.isNull(builder.getAttrName())) { + builder.attrName(this.attrName); + } + }); + return builders.stream() + .map(ValidatorBaseBuilder::build) + .collect(Collectors.toList()); + + + } + protected List> initValidators() { return initAndBuildList(this.validatorBuilders); } @@ -70,4 +95,4 @@ private List initAndBuildList(List build() { - List> groups = initAndBuildList(this.validatorGroupBuilders); + List> groups = initAndBuildGroupList(this.validatorGroupBuilders); List> validators = initAndBuildList(this.validatorBuilders); return new ValidatorGroup<>(validators, groups, valueGetter, conditionGetter); } + // Note: exact same functionality as initAndBuildList, just needed a different call signature. + // This method was added to enable development using Eclipse + private List> initAndBuildGroupList(List> builders) { + + builders.forEach(builder -> { + if (Objects.nonNull(this.errorMessage)) { + builder.errorMessage(this.errorMessage); + } + if (Objects.isNull(builder.getBasePath())) { + builder.basePath(createChildPath()); + } + if (Objects.isNull(builder.severity)) { + builder.severity(this.severity); + } + }); + return builders.stream() + .map(ValidatorBaseBuilder::build) + .collect(Collectors.toList()); + + + } + private List initAndBuildList(List> builders) { builders.forEach(builder -> { @@ -89,4 +111,4 @@ private List initAndBuildList(List Date: Mon, 4 Nov 2024 12:12:40 -0500 Subject: [PATCH 2/2] Removed empty mvn file. --- mvn | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 mvn diff --git a/mvn b/mvn deleted file mode 100644 index e69de29bb2..0000000000