Merge branch 'feature/54171_fix_upgrade_client_and_settings_script' into 'master'

Client upgrade and settings script: don't delete parameters.json for the...

See merge request os2borgerpc/os2borgerpc-scripts!167

Author: Marcus Funch

common/system/upgrade_client.sh

@@ -1,4 +1,5 @@
-#!/bin/bash
+#!/usr/bin/env sh
 
-pip3 install --upgrade os2borgerpc-client
+set -ex
 
+pip3 install --upgrade os2borgerpc-client

common/system/upgrade_client_and_settings.sh

@@ -0,0 +1,24 @@
+#!/usr/bin/env sh
+
+# Updates the OSborgerPC client and settings
+# Not relevant for new machines as they have saner defaults, but it's a good idea when upgrading older machines (machines instaled from images 3.1.0 (maybe even 3.1.1) or older)
+
+set -ex
+
+# IMPORTANT!: Remove old events identified, as this file may contain the same event duplicated many times in older clients.
+rm --force /etc/os2borgerpc/security/securityevent.csv
+
+# Remove old parameters.json for all previous jobs (status is DONE or FAILED) as they may contain sensitive information
+for j in /var/lib/os2borgerpc/jobs/*; do
+  if [ "$(cat "$j"/status)" = "DONE" ] || [ "$(cat "$j"/status)" = "FAILED" ]; then
+      rm --force "$j/parameters.json"
+  fi
+done
+
+# Set the correct, more restrictive permissions on all previous jobs
+chmod --recursive 700 /var/lib/os2borgerpc
+
+# More restrictive permissions on /home/superuser
+chmod -R 700 /home/superuser
+
+pip3 install --upgrade os2borgerpc-client