Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] g.extension fails to install #5139

Closed
dhdeangelis opened this issue Feb 18, 2025 · 8 comments · Fixed by #5141
Closed

[Bug] g.extension fails to install #5139

dhdeangelis opened this issue Feb 18, 2025 · 8 comments · Fixed by #5141
Labels
bug Something isn't working

Comments

@dhdeangelis
Copy link
Contributor

Describe the bug

g.extension fails to install an extension. It reports an error seemingly attempting to read a non-existing file.

To reproduce

  1. Go to 'Install extension from addons'
  2. Select an extension, in this example 'r.area'
  3. See error
> g.extension extension=r.area operation=add
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), done.
Total 1 (delta 0), reused 1 (delta 0), pack-reused 0 (from 0)
Fetching <r.area> from <https://github.com/OSGeo/grass-addons/> (be
patient)...
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), done.
Total 1 (delta 0), reused 1 (delta 0), pack-reused 0 (from 0)
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 21 (delta 0), reused 0 (delta 0), pack-reused 12 (from 1)
Receiving objects: 100% (21/21), 23.20 KiB | 2.32 MiB/s, done.
Already on 'grass8'
Your branch is up to date with 'origin/grass8'.
Compiling...
/bin/sh: line 1: /usr/local/grass85/docs/mkdocs/source/r.area.md: Permission denied
make: *** [/usr/local/grass85/include/Make/Html.make:11: /usr/local/grass85/docs/mkdocs/source/r.area.md] Error 1
ERROR: Compilation failed, sorry. Please check above error messages

Note that "r.area.md" is not present in "/usr/local/grass85/docs/mkdocs/source" nor in the local .grass8 folder.

Expected behavior

Addon installs correctly in local (user space) directory for addons.

System description

GRASS version: 8.5.0dev                                                         
Code revision: d8d8d84c8b                                                       
Build date: 2025-02-17                                                          
Build platform: x86_64-pc-linux-gnu                                             
GDAL: 3.11.0dev-122979cca4-dirty                                                
PROJ: 9.6.0                                                                     
GEOS: 3.14.0dev                                                                 
SQLite: 3.48.0                                                                  
Python: 3.11.11                                                                 
wxPython: 4.2.2                                                                 
Platform: Linux-6.13.2-1-default-x86_64-with-glibc2.40 

Additional context

I have other 3 addons installed with a previous GRASS installation. These are correctly installed locally in .grass8:

> echo $GRASS_ADDON_BASE
/home/hernan/.grass8/addons
@dhdeangelis dhdeangelis added the bug Something isn't working label Feb 18, 2025
@echoix
Copy link
Member

echoix commented Feb 18, 2025

If we look at the CI logs of grass-addons (and even locally), every single addons (maybe with some exceptions) show this, but doesn't make the build fail.

@dhdeangelis
Copy link
Contributor Author

It is failing in my case. Last time I installed addons was on 9th February and worked ok then.Now I cannot even reinstall the existing ones, failing on same issue.

@dhdeangelis
Copy link
Contributor Author

I have now deleted my local .grass8 folder and /usr/local/grass85, and then rebuilt GRASS using the latest (938b9ad) main. The problem persists.

@veroandreo
Copy link
Contributor

It seems to be searching for the documentation as md files, which for addons do not exist yet. And in dev, it changed during the past week or so.

@petrasovaa
Copy link
Contributor

I runs for me locally, we tried to address it at least in a temporary way before the transition is complete. Try to use prefix and see if that changes anything.

@dhdeangelis
Copy link
Contributor Author

Thank you @petrasovaa , but it does not change things for me:

> g.extension extension=r.object.spatialautocor prefix=/home/hernan/.grass8
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), done.
Total 1 (delta 0), reused 1 (delta 0), pack-reused 0 (from 0)
Fetching <r.object.spatialautocor> from
<https://github.com/OSGeo/grass-addons/> (be patient)...
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), done.
Total 1 (delta 0), reused 1 (delta 0), pack-reused 0 (from 0)
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 21 (delta 0), reused 0 (delta 0), pack-reused 12 (from 1)
Receiving objects: 100% (21/21), 23.48 KiB | 2.13 MiB/s, done.
Already on 'grass8'
Your branch is up to date with 'origin/grass8'.
Compiling...
/bin/sh: line 1: /usr/local/grass85/docs/mkdocs/source/r.object.spatialautocor.md: Permission denied
make: *** [/usr/local/grass85/include/Make/Html.make:11: /usr/local/grass85/docs/mkdocs/source/r.object.spatialautocor.md] Error 1
ERROR: Compilation failed, sorry. Please check above error messages.

@petrasovaa
Copy link
Contributor

Any chance you could test #5141 ?

wenzeslaus pushed a commit that referenced this issue Feb 19, 2025
Broken after Markdown docs transition. Markdown needs it special addons path just like the others, otherwise it goes to the system directory (and fails without permissions).

See #5139.
@dhdeangelis
Copy link
Contributor Author

It works fine. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants