Note type table not regenerating with new fields

[eyesmool]

When I add / remove fields in anki, the fields are not regenerating when I press the Regenerate Note Type Table. I have to reinstall the Obsidian plugin for it to update.

[eyesmool]

Fix for Regenerate Note Type Table Button

Problem

The "Regenerate Note Type Table" button does not refresh when Anki note type fields are modified on existing cards. It only works when note types are added or deleted entirely.

Root Cause

In the regenerate button handler (lines 406-431), the code checks if the fields dictionary needs updating by comparing the count of note types:

if (Object.keys(plugin.fields_dict).length != plugin.note_types.length) {
    // Only regenerates if the NUMBER of note types changed
    plugin.fields_dict = await plugin.generateFieldsDict();
}

This misses cases where:

• Fields are added to an existing note type
• Fields are removed from an existing note type
• Fields are renamed in an existing note type

Solution

Replace the count-based check with a check that always regenerates the fields dictionary, or add logic to detect field changes.

Option 1: Always Regenerate (Recommended - Simple & Reliable)

Location: Line 412-423 in the regenerate button onClick handler

Replace:

plugin.fields_dict = await plugin.loadFieldsDict();
if (Object.keys(plugin.fields_dict).length != plugin.note_types.length) {
    new obsidian.Notice('Need to connect to Anki to generate fields dictionary...');
    try {
        plugin.fields_dict = await plugin.generateFieldsDict();
        new obsidian.Notice("Fields dictionary successfully generated!");
    }
    catch (e) {
        new obsidian.Notice("Couldn't connect to Anki! Check console for error message.");
        return;
    }
}

With:

// Always regenerate fields dictionary when user clicks regenerate button
new obsidian.Notice('Regenerating fields dictionary from Anki...');
try {
    plugin.fields_dict = await plugin.generateFieldsDict();
    new obsidian.Notice("Fields dictionary successfully generated!");
}
catch (e) {
    new obsidian.Notice("Couldn't connect to Anki! Check console for error message.");
    return;
}

Option 2: Detect Field Changes (More Complex)

Add a helper function to check if fields have changed:

async hasFieldsChanged() {
    const currentFieldsDict = await this.generateFieldsDict();
    
    // Check if note types match
    const currentNoteTypes = Object.keys(currentFieldsDict).sort();
    const cachedNoteTypes = Object.keys(this.fields_dict).sort();
    
    if (currentNoteTypes.length !== cachedNoteTypes.length) {
        return true;
    }
    
    if (JSON.stringify(currentNoteTypes) !== JSON.stringify(cachedNoteTypes)) {
        return true;
    }
    
    // Check if fields for each note type match
    for (let noteType of currentNoteTypes) {
        const currentFields = currentFieldsDict[noteType].sort();
        const cachedFields = (this.fields_dict[noteType] || []).sort();
        
        if (JSON.stringify(currentFields) !== JSON.stringify(cachedFields)) {
            return true;
        }
    }
    
    return false;
}

Then in the regenerate button handler:

plugin.fields_dict = await plugin.loadFieldsDict();
const fieldsChanged = await plugin.hasFieldsChanged();

if (fieldsChanged) {
    new obsidian.Notice('Detecting field changes, regenerating fields dictionary...');
    try {
        plugin.fields_dict = await plugin.generateFieldsDict();
        new obsidian.Notice("Fields dictionary successfully generated!");
    }
    catch (e) {
        new obsidian.Notice("Couldn't connect to Anki! Check console for error message.");
        return;
    }
} else {
    new obsidian.Notice("No field changes detected.");
}

Recommendation

Use Option 1 (always regenerate). Since the user is explicitly clicking "Regenerate Note Type Table", it makes sense to always refresh the fields dictionary from Anki. This is:

• Simpler to implement
• More reliable
• Matches user expectations (they clicked "regenerate")
• Still efficient (only happens on manual button click)

The performance cost is minimal since this is a manual action triggered by the user who is already expecting to wait for Anki communication.

Testing

After applying the fix:

1. Open Anki and modify a note type (add/remove/rename a field)
2. In Obsidian, click "Regenerate Note Type Table"
3. Verify that the dropdown menus for "File Link Field" and "Context Field" now show the updated field list
4. Verify that new notes created use the updated field structure

[IamBugs]

Thank you so much! Worked like a charm