Skip to content

Commit 3d9fe08

Browse files
committed
fix
1 parent a8817ec commit 3d9fe08

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/createRollup.integration.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,5 @@ it(`successfully deploys core contracts through rollup creator`, async () => {
7474
);
7575

7676
expect(txReceipt.status).toEqual('success');
77-
expect(txReceipt.getCoreContracts()).not.toThrowError();
77+
expect(() => txReceipt.getCoreContracts()).not.toThrowError();
7878
});

src/createRollup.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,14 @@ export async function createRollup({
5858
}
5959

6060
const maxDataSize = createRollupGetMaxDataSize(chainId);
61+
const paramsWithDefaults = { ...defaults, ...params, maxDataSize };
6162

6263
const { request } = await publicClient.simulateContract({
6364
address: rollupCreator.address[chainId],
6465
abi: rollupCreator.abi,
6566
functionName: 'createRollup',
66-
args: [{ ...defaults, ...params, maxDataSize }],
67-
value: createRollupGetCallValue(params),
67+
args: [paramsWithDefaults],
68+
value: createRollupGetCallValue(paramsWithDefaults),
6869
account,
6970
});
7071

src/createRollupPrepareTransactionRequest.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Address, PublicClient, encodeFunctionData } from 'viem';
22

3-
import { CreateRollupParams } from './createRollup';
3+
import { CreateRollupFunctionInputs, CreateRollupParams } from './createRollup';
44
import { defaults } from './createRollupDefaults';
55
import { createRollupGetCallValue } from './createRollupGetCallValue';
66
import { createRollupGetMaxDataSize } from './createRollupGetMaxDataSize';
@@ -10,13 +10,11 @@ import { isCustomFeeTokenAddress } from './utils/isCustomFeeTokenAddress';
1010
import { ChainConfig } from './types/ChainConfig';
1111
import { isAnyTrustChainConfig } from './utils/isAnyTrustChainConfig';
1212

13-
function createRollupEncodeFunctionData(
14-
params: CreateRollupParams & { maxDataSize: bigint }
15-
) {
13+
function createRollupEncodeFunctionData(args: CreateRollupFunctionInputs) {
1614
return encodeFunctionData({
1715
abi: rollupCreator.abi,
1816
functionName: 'createRollup',
19-
args: [{ ...defaults, ...params }],
17+
args,
2018
});
2119
}
2220

@@ -47,12 +45,13 @@ export async function createRollupPrepareTransactionRequest({
4745
}
4846

4947
const maxDataSize = createRollupGetMaxDataSize(chainId);
48+
const paramsWithDefaults = { ...defaults, ...params, maxDataSize };
5049

5150
const request = await publicClient.prepareTransactionRequest({
5251
chain: publicClient.chain,
5352
to: rollupCreator.address[chainId],
54-
data: createRollupEncodeFunctionData({ ...params, maxDataSize }),
55-
value: createRollupGetCallValue(params),
53+
data: createRollupEncodeFunctionData([paramsWithDefaults]),
54+
value: createRollupGetCallValue(paramsWithDefaults),
5655
account,
5756
});
5857

0 commit comments

Comments
 (0)