Merge pull request #321 from OffchainLabs/gettransaction-apibackend-bugfix

joshuacolvin0 · web-flow · commit 021ff6fb50c7 · 2024-05-23T16:31:06.000-07:00
Arbitrum APIBackend's GetTransaction should return false when tx is not found
diff --git a/arbitrum/apibackend.go b/arbitrum/apibackend.go
@@ -614,7 +614,7 @@ func (a *APIBackend) SendConditionalTx(ctx context.Context, signedTx *types.Tran
 
 func (a *APIBackend) GetTransaction(ctx context.Context, txHash common.Hash) (bool, *types.Transaction, common.Hash, uint64, uint64, error) {
 	tx, blockHash, blockNumber, index := rawdb.ReadTransaction(a.b.chainDb, txHash)
-	return true, tx, blockHash, blockNumber, index, nil
+	return tx != nil, tx, blockHash, blockNumber, index, nil
 }
 
 func (a *APIBackend) GetPoolTransactions() (types.Transactions, error) {

Original file line number	Diff line number	Diff line change
`@@ -614,7 +614,7 @@ func (a APIBackend) SendConditionalTx(ctx context.Context, signedTx types.Tran`
`614`	`614`
`615`	`615`	`func (a APIBackend) GetTransaction(ctx context.Context, txHash common.Hash) (bool, types.Transaction, common.Hash, uint64, uint64, error) {`
`616`	`616`	`tx, blockHash, blockNumber, index := rawdb.ReadTransaction(a.b.chainDb, txHash)`
`617`		`- return true, tx, blockHash, blockNumber, index, nil`
	`617`	`+ return tx != nil, tx, blockHash, blockNumber, index, nil`
`618`	`618`	`}`
`619`	`619`
`620`	`620`	`func (a *APIBackend) GetPoolTransactions() (types.Transactions, error) {`