Merge pull request #376 from OffchainLabs/pebble-no-sync

joshuacolvin0 · web-flow · commit 6ec497de3387 · 2024-12-20T11:44:50.000-05:00
add SyncMode option to PebbleExtraOptions
diff --git a/ethdb/pebble/extraoptions.go b/ethdb/pebble/extraoptions.go
@@ -3,6 +3,7 @@ package pebble
 import "time"
 
 type ExtraOptions struct {
+	SyncMode                    bool
 	BytesPerSync                int
 	L0CompactionFileThreshold   int
 	L0CompactionThreshold       int
diff --git a/ethdb/pebble/pebble.go b/ethdb/pebble/pebble.go
@@ -238,7 +238,7 @@ func New(file string, cache int, handles int, namespace string, readonly bool, e
 		fn:           file,
 		log:          logger,
 		quitChan:     make(chan chan error),
-		writeOptions: &pebble.WriteOptions{Sync: !ephemeral},
+		writeOptions: &pebble.WriteOptions{Sync: !ephemeral && extraOptions.SyncMode},
 	}
 	opt := &pebble.Options{
 		// Pebble has a single combined cache area and the write

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ func New(file string, cache int, handles int, namespace string, readonly bool, e`
`238`	`238`	`fn: file,`
`239`	`239`	`log: logger,`
`240`	`240`	`quitChan: make(chan chan error),`
`241`		`- writeOptions: &pebble.WriteOptions{Sync: !ephemeral},`
	`241`	`+ writeOptions: &pebble.WriteOptions{Sync: !ephemeral && extraOptions.SyncMode},`
`242`	`242`	`}`
`243`	`243`	`opt := &pebble.Options{`
`244`	`244`	`// Pebble has a single combined cache area and the write`