Skip to content

Commit cd51f51

Browse files
authored
Merge pull request #411 from OffchainLabs/rm_finality_syncmonitor
Removes FinalizedBlockNumber and SafeBlockNumber from SyncProgressMap
2 parents 6c1a197 + 7ce5b7b commit cd51f51

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

arbitrum/apibackend.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ func CreateFallbackClient(fallbackClientUrl string, fallbackClientTimeout time.D
121121

122122
type SyncProgressBackend interface {
123123
SyncProgressMap() map[string]interface{}
124-
SafeBlockNumber(ctx context.Context) (uint64, error)
125-
FinalizedBlockNumber(ctx context.Context) (uint64, error)
126124
BlockMetadataByNumber(blockNum uint64) (common.BlockMetadata, error)
127125
}
128126

@@ -407,13 +405,23 @@ func (a *APIBackend) blockNumberToUint(ctx context.Context, number rpc.BlockNumb
407405
if a.sync == nil {
408406
return 0, errors.New("block number not supported: object not set")
409407
}
410-
return a.sync.SafeBlockNumber(ctx)
408+
409+
currentSafeBlock := a.BlockChain().CurrentSafeBlock()
410+
if currentSafeBlock == nil {
411+
return 0, errors.New("safe block not found")
412+
}
413+
return currentSafeBlock.Number.Uint64(), nil
411414
}
412415
if number == rpc.FinalizedBlockNumber {
413416
if a.sync == nil {
414417
return 0, errors.New("block number not supported: object not set")
415418
}
416-
return a.sync.FinalizedBlockNumber(ctx)
419+
420+
currentFinalizedBlock := a.BlockChain().CurrentFinalBlock()
421+
if currentFinalizedBlock == nil {
422+
return 0, errors.New("finalized block not found")
423+
}
424+
return currentFinalizedBlock.Number.Uint64(), nil
417425
}
418426
if number < 0 {
419427
return 0, errors.New("block number not supported")

0 commit comments

Comments
 (0)