From ed16798602b9b25889230d862f85ca88f0f272e0 Mon Sep 17 00:00:00 2001 From: ganeshvanahalli Date: Wed, 22 Nov 2023 22:17:46 +0530 Subject: [PATCH 1/2] Increase the default BatchPosterConfig MaxSize for DAS chains to ~1MB --- cmd/nitro/nitro.go | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/cmd/nitro/nitro.go b/cmd/nitro/nitro.go index 42ba54c642..9cfb5a04e6 100644 --- a/cmd/nitro/nitro.go +++ b/cmd/nitro/nitro.go @@ -826,14 +826,19 @@ func applyChainParameters(ctx context.Context, k *koanf.Koanf, chainId uint64, c chainDefaults["init.empty"] = true } if parentChainIsArbitrum { - l2MaxTxSize := gethexec.DefaultSequencerConfig.MaxTxDataSize - bufferSpace := 5000 - if l2MaxTxSize < bufferSpace*2 { - return false, fmt.Errorf("not enough room in parent chain max tx size %v for bufferSpace %v * 2", l2MaxTxSize, bufferSpace) - } - safeBatchSize := l2MaxTxSize - bufferSpace - chainDefaults["node.batch-poster.max-size"] = safeBatchSize - chainDefaults["node.sequencer.max-tx-data-size"] = safeBatchSize - bufferSpace + if chainInfo.DasIndexUrl != "" { + chainDefaults["node.batch-poster.max-size"] = 1000000 + chainDefaults["node.sequencer.max-tx-data-size"] = 995000 + } else { + l2MaxTxSize := gethexec.DefaultSequencerConfig.MaxTxDataSize + bufferSpace := 5000 + if l2MaxTxSize < bufferSpace*2 { + return false, fmt.Errorf("not enough room in parent chain max tx size %v for bufferSpace %v * 2", l2MaxTxSize, bufferSpace) + } + safeBatchSize := l2MaxTxSize - bufferSpace + chainDefaults["node.batch-poster.max-size"] = safeBatchSize + chainDefaults["node.sequencer.max-tx-data-size"] = safeBatchSize - bufferSpace + } } err = k.Load(confmap.Provider(chainDefaults, "."), nil) if err != nil { From 8319b177c948bc36487191ccbd66474fc48c64d9 Mon Sep 17 00:00:00 2001 From: ganeshvanahalli Date: Wed, 22 Nov 2023 22:40:57 +0530 Subject: [PATCH 2/2] address PR comments --- cmd/nitro/nitro.go | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/cmd/nitro/nitro.go b/cmd/nitro/nitro.go index 9cfb5a04e6..1dc898df11 100644 --- a/cmd/nitro/nitro.go +++ b/cmd/nitro/nitro.go @@ -826,19 +826,17 @@ func applyChainParameters(ctx context.Context, k *koanf.Koanf, chainId uint64, c chainDefaults["init.empty"] = true } if parentChainIsArbitrum { - if chainInfo.DasIndexUrl != "" { - chainDefaults["node.batch-poster.max-size"] = 1000000 - chainDefaults["node.sequencer.max-tx-data-size"] = 995000 - } else { - l2MaxTxSize := gethexec.DefaultSequencerConfig.MaxTxDataSize - bufferSpace := 5000 - if l2MaxTxSize < bufferSpace*2 { - return false, fmt.Errorf("not enough room in parent chain max tx size %v for bufferSpace %v * 2", l2MaxTxSize, bufferSpace) - } - safeBatchSize := l2MaxTxSize - bufferSpace - chainDefaults["node.batch-poster.max-size"] = safeBatchSize - chainDefaults["node.sequencer.max-tx-data-size"] = safeBatchSize - bufferSpace + l2MaxTxSize := gethexec.DefaultSequencerConfig.MaxTxDataSize + bufferSpace := 5000 + if l2MaxTxSize < bufferSpace*2 { + return false, fmt.Errorf("not enough room in parent chain max tx size %v for bufferSpace %v * 2", l2MaxTxSize, bufferSpace) } + safeBatchSize := l2MaxTxSize - bufferSpace + chainDefaults["node.batch-poster.max-size"] = safeBatchSize + chainDefaults["node.sequencer.max-tx-data-size"] = safeBatchSize - bufferSpace + } + if chainInfo.DasIndexUrl != "" { + chainDefaults["node.batch-poster.max-size"] = 1000000 } err = k.Load(confmap.Provider(chainDefaults, "."), nil) if err != nil {