Skip to content

Commit 2c64ef1

Browse files
committed
Review fixes
1 parent 4984821 commit 2c64ef1

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

contracts/child-chain/stylus/AddWasmCacheManagerAction.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-License-Identifier: Apache-2.0
1+
// SPDX-License-Identifier: Apache-2.0
22
pragma solidity 0.8.16;
33

44
import "@arbitrum/nitro-contracts-2.0.0/src/precompiles/ArbSys.sol";

contracts/parent-chain/contract-upgrades/NitroContracts2Point0Point0UpgradeAction.sol

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ contract NitroContracts2Point0Point0UpgradeAction {
3636
address public immutable newRollupAdminLogic;
3737
address public immutable newRollupUserLogic;
3838

39-
bytes32 private constant _IMPLEMENTATION_PRIMARY_SLOT =
40-
0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc;
41-
bytes32 internal constant _IMPLEMENTATION_SECONDARY_SLOT =
42-
0x2b1dbce74324248c222f0ec2d5ed7bd323cfc425b336f0253c5ccfda7265546d;
43-
4439
constructor(
4540
bytes32 _newWasmModuleRoot,
4641
address _newChallengeManagerImpl,
@@ -125,12 +120,10 @@ contract NitroContracts2Point0Point0UpgradeAction {
125120

126121
function _upgradeRollup(address rollupProxy) internal {
127122
IRollupUpgrade rollup = IRollupUpgrade(rollupProxy);
128-
address _newAdminLogic = newRollupAdminLogic;
129-
address _newUserLogic = newRollupUserLogic;
130123

131124
// set new logic contracts
132-
rollup.upgradeTo(_newAdminLogic);
133-
rollup.upgradeSecondaryTo(_newUserLogic);
125+
rollup.upgradeTo(newRollupAdminLogic);
126+
rollup.upgradeSecondaryTo(newRollupUserLogic);
134127

135128
// verify
136129
require(

scripts/foundry/contract-upgrades/2.0.0/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,3 @@ If you have a multisig as executor, you can still run the above command without
4949
```bash
5050
cast call --rpc-url $PARENT_CHAIN_RPC $ROLLUP "wasmModuleRoot()"
5151
```
52-
53-
54-
55-
forge script --private-key XXX --rpc-url $PARENT_CHAIN_RPC --slow --broadcast ./DeployNitroContracts2Point0Point0UpgradeAction.s.sol:DeployNitroContracts2Point0Point0UpgradeActionScript -vvv

0 commit comments

Comments
 (0)