-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set labels for ATE Gen3 #347
Conversation
I believe we can merge this already because we are just updating the labels. @OnTheGoSystems/compatibility |
Note that we don't need specific labels for every element because we try to put together the label automatically. We only set a specific label when the automatic label doesn't match the requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgwatkins, I quickly scanned the changes and it looks good. The only question is about the order of the items in the config: Our current config does not respect a clear order (alphabetical or other), and in your changes you also changed the order of some items, but still it's not alphabetical. Did you opted for another specific order?
No @strategio As far as I can see, the order of the XML elements has nothing to do with it. The problem of the string_location is that we only use it in page-builders. I did change the order of divi shortcode definitions to confirm this (et_pb_cta). I left it changed because it makes more sense to have the titles at the top and the rest below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @dgwatkins
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-419