Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[The7] Added config file with override_local false #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrescifuentesr
Copy link
Collaborator

@dgwatkins
Copy link
Collaborator

@andrescifuentesr do you know if "The7" author has been keeping his XML up to date? I am asking because as soon as I merge this, all "The7" users will stop receiving our XML and start using their local XML.

FYI: @gerasimovdaniel

@andrescifuentesr
Copy link
Collaborator Author

@gerasimovdaniel, do you think is better to wait until The7 new version is released and give time for your users to update and then remove it? Or maybe you just prefer to keep maintaining our repository as you did this morning?
Let us know your thoughts.

@gerasimovdaniel
Copy link
Contributor

gerasimovdaniel commented Apr 5, 2024

@andrescifuentesr, I prefer to keep the XML in The7. We are keeping it up to date quite rigorously. Let's wait until the new version of The7 is released. Should I post here when it comes?

@andrescifuentesr
Copy link
Collaborator Author

@gerasimovdaniel, sure. Please let us know once the new version is released so we can go further.
Let's hold this on @dgwatkins.

@gerasimovdaniel
Copy link
Contributor

gerasimovdaniel commented Apr 15, 2024

@dgwatkins @andrescifuentesr The7 new version is released.

@diiegopereira
Copy link
Collaborator

Implementing this change may cause issues for users with older versions of The7 theme, where the new XML file has not yet been implemented. The WPML integration will suddenly stop working.

The solution in this case would be to keep both files synchronized (local and remote) for a while, until most users have updated the theme.

I talked to Yana via email and we decided to wait around a year to do this modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants