adding correlationId and timestamp fields for easy debugging/investigations. Also refactored the code to reduce painpoints in debugging due to redundent code spread across codebase

Author: sharaaU7

OneNoteServiceSamplesWinUniversal.Shared/DataModel/ItemPageModel.cs

@@ -11,12 +11,16 @@ namespace OneNoteServiceSamplesWinUniversal.DataModel
 {
 	public class ItemPageModel : INotifyPropertyChanged
 	{
-		private string _authUserName = null;  // Logged in user name
-		private SampleDataItem _item = null;  // Info about the current item
-		private object _apiResponse = null;  // Response from an API request - Either a ApiBaseResponse or a List<ApiBaseResponse>
-		private ApiBaseResponse _selectedResponse = null;  // Holds a reference to the currently selected response
+		private string _authUserName = null; // Logged in user name
+		private SampleDataItem _item = null; // Info about the current item
+		private HubContext _userData = null;
+		private object _apiResponse = null;
+			// Response from an API request - Either a ApiBaseResponse or a List<ApiBaseResponse>
 
-		public event PropertyChangedEventHandler PropertyChanged;  // Implements INotifyPropertyChanged for notifying the binding engine when an attribute changes
+		private ApiBaseResponse _selectedResponse = null; // Holds a reference to the currently selected response
+
+		public event PropertyChangedEventHandler PropertyChanged;
+			// Implements INotifyPropertyChanged for notifying the binding engine when an attribute changes
 
 		/// <summary>
 		// NotifyPropertyChanged will fire the PropertyChanged event, 
@@ -32,10 +36,7 @@ public void NotifyPropertyChanged(string propertyName)
 
 		public string AuthUserName
 		{
-			get
-			{
-				return _authUserName;
-			}
+			get { return _authUserName; }
 
 			set
 			{
@@ -62,10 +63,7 @@ public string SignInButtonTitle
 
 		public SampleDataItem Item
 		{
-			get
-			{
-				return _item;
-			}
+			get { return _item; }
 
 			set
 			{
@@ -85,14 +83,18 @@ public object ApiResponse
 
 				if (_apiResponse != null)
 				{
-					if (_apiResponse is ApiBaseResponse)
+					var response = _apiResponse as ApiBaseResponse;
+					if (response != null)
 					{
-						selectedResponse = _apiResponse as ApiBaseResponse;
+						selectedResponse = response;
 					}
 					else
 					{
-						List<ApiBaseResponse> multipleResponses = _apiResponse as List<ApiBaseResponse>;
-						selectedResponse = multipleResponses[0];
+						var multipleResponses = _apiResponse as List<ApiBaseResponse>;
+						if (multipleResponses != null)
+						{
+							selectedResponse = multipleResponses[0];
+						}
 					}
 				}
 
@@ -105,15 +107,13 @@ public object ApiResponse
 				NotifyPropertyChanged("IsClientUrlAvailable");
 				NotifyPropertyChanged("ResponseList");
 				NotifyPropertyChanged("SelectedResponse");
+				NotifyPropertyChanged("CorrelationId");
 			}
 		}
 
 		public ApiBaseResponse SelectedResponse
 		{
-			get
-			{
-				return _selectedResponse;
-			}
+			get { return _selectedResponse; }
 
 			set
 			{
@@ -123,6 +123,17 @@ public ApiBaseResponse SelectedResponse
 			}
 		}
 
+		public HubContext UserData
+		{
+			get { return _userData; }
+
+			set
+			{
+				_userData = value;
+				NotifyPropertyChanged("TimeStamp");
+			}
+		}
+
 		public string StatusCode
 		{
 			get
@@ -135,7 +146,7 @@ public string StatusCode
 
 					if (statusCode != 0)
 					{
-						statusCodeString = string.Format("{0}-{1}", (int)statusCode, statusCode.ToString());
+						statusCodeString = string.Format("{0}-{1}", (int) statusCode, statusCode.ToString());
 					}
 				}
 
@@ -175,10 +186,7 @@ public Thickness BodyBorderThikness
 
 		public bool IsResponseAvailable
 		{
-			get
-			{
-				return _apiResponse != null;
-			}
+			get { return _apiResponse != null; }
 		}
 
 		public Visibility IsResponseListAvailable
@@ -198,10 +206,7 @@ public Visibility IsResponseListAvailable
 
 		public List<ApiBaseResponse> ResponseList
 		{
-			get
-			{
-				return _apiResponse as List<ApiBaseResponse>;
-			}
+			get { return _apiResponse as List<ApiBaseResponse>; }
 		}
 
 		public Visibility IsClientUrlAvailable
@@ -248,5 +253,23 @@ public string OneNoteWebUrl
 				return webUrl;
 			}
 		}
+
+		public string CorrelationId
+		{
+			get
+			{
+				return _selectedResponse != null && !string.IsNullOrEmpty(_selectedResponse.CorrelationId)
+					? _selectedResponse.CorrelationId
+					: string.Empty;
+			}
+		}
+
+		public string TimeStamp
+		{
+			get
+			{
+				return _userData != null ? _userData.TimeStamp.ToString() : string.Empty;
+			}
+		}
 	}
 }

OneNoteServiceSamplesWinUniversal.Shared/OneNoteApi/HttpUtils.cs

@@ -0,0 +1,48 @@
+using System.Collections.Generic;
+using System.Linq;
+using System.Net;
+using System.Net.Http;
+using System.Threading.Tasks;
+using Newtonsoft.Json;
+
+namespace OneNoteServiceSamplesWinUniversal.OneNoteApi
+{
+    public static class HttpUtils
+    {
+		#region Helper methods used in the examples
+
+	    /// <summary>
+	    /// Convert the HTTP response message into a simple structure suitable for apps to process
+	    /// </summary>
+	    /// <param name="response">The response to convert</param>
+	    /// <param name="expectedStatusCode"></param>
+	    /// <returns>A simple response</returns>
+	    public static async Task<ApiBaseResponse> TranslateResponse(HttpResponseMessage response, HttpStatusCode expectedStatusCode = HttpStatusCode.Created)
+	    {
+		    ApiBaseResponse apiBaseResponse;
+		    string body = await response.Content.ReadAsStringAsync();
+			if (response.StatusCode == expectedStatusCode
+			    /* POST calls always return 201-Created upon success */)
+		    {
+			    apiBaseResponse = JsonConvert.DeserializeObject<GenericEntityResponse>(body);
+		    }
+		    else
+		    {
+			    apiBaseResponse = new ApiBaseResponse();
+		    }
+
+		    // Extract the correlation id.  Apps should log this if they want to collect the data to diagnose failures with Microsoft support 
+		    IEnumerable<string> correlationValues;
+		    if (response.Headers.TryGetValues("X-CorrelationId", out correlationValues))
+		    {
+			    apiBaseResponse.CorrelationId = correlationValues.FirstOrDefault();
+		    }
+		    apiBaseResponse.StatusCode = response.StatusCode;
+		    apiBaseResponse.Body = body;
+		    return apiBaseResponse;
+	    }
+
+	    #endregion
+
+    }
+}

OneNoteServiceSamplesWinUniversal.Shared/OneNoteApi/Notebooks/PostNotebooksExample.cs

@@ -16,9 +16,6 @@
 // See the Apache Version 2.0 License for specific language 
 // governing permissions and limitations under the License.
 //*********************************************************
-
-using Newtonsoft.Json;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
 using System.Net;
@@ -92,43 +89,10 @@ public static async Task<ApiBaseResponse> CreateSimpleNotebook(bool debug, strin
 
 			HttpResponseMessage response = await client.SendAsync(createMessage);
 
-			return await TranslateResponse(response);
+			return await HttpUtils.TranslateResponse(response);
 		}
 
 		#endregion
 
-		#region Helper methods used in the examples
-
-		/// <summary>
-		/// Convert the HTTP response message into a simple structure suitable for apps to process
-		/// </summary>
-		/// <param name="response">The response to convert</param>
-		/// <returns>A simple response</returns>
-		private static async Task<ApiBaseResponse> TranslateResponse(HttpResponseMessage response)
-		{
-			ApiBaseResponse apiBaseResponse;
-			string body = await response.Content.ReadAsStringAsync();
-			if (response.StatusCode == HttpStatusCode.Created
-				/* POST calls always return 201-Created upon success */)
-			{
-				apiBaseResponse = JsonConvert.DeserializeObject<GenericEntityResponse>(body);
-			}
-			else
-			{
-				apiBaseResponse = new ApiBaseResponse();
-			}
-
-			// Extract the correlation id.  Apps should log this if they want to collect the data to diagnose failures with Microsoft support 
-			IEnumerable<string> correlationValues;
-			if (response.Headers.TryGetValues("X-CorrelationId", out correlationValues))
-			{
-				apiBaseResponse.CorrelationId = correlationValues.FirstOrDefault();
-			}
-			apiBaseResponse.StatusCode = response.StatusCode;
-			apiBaseResponse.Body = body;
-			return apiBaseResponse;
-		}
-
-		#endregion
 	}
 }