Fix whitespace, version, and syntax

Fix whitespace, versioning, and clean up syntax

Author: JaneHazen

.gitignore

@@ -18,3 +18,5 @@ yarn-error.log*
 
 # IDE Specific Ignores
 .idea
+
+.vscode

.vscode/launch.json

@@ -1,6 +1,6 @@
 {
   "name": "onenotepicker",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "files": [
     "dist/**/*"
   ],

.vscode/settings.json

@@ -48,13 +48,11 @@ oneNoteDataProvider.getNotebooks().then((notebooks) => {
 			notebookListUpdater: updater,
 			callbacks: {
 				onNotebookHierarchyUpdated: (newNotebookHierarchy) => {
-				
 					render(globalProps, newNotebookHierarchy);
 					renderDropdown(globalProps, newNotebookHierarchy);
 				},
 				onSectionSelected: (section, breadcrumbs) => {
 					globalProps.globals.selectedId = section.id;
-			
 					// tslint:disable-next-line:no-console
 					console.log(breadcrumbs.map(x => x.name).join(' > '));
 
@@ -63,7 +61,6 @@ oneNoteDataProvider.getNotebooks().then((notebooks) => {
 				},
 				onPageSelected: (page, breadcrumbs) => {
 					globalProps.globals.selectedId = page.id;
-
 					// tslint:disable-next-line:no-console
 					console.log(breadcrumbs.map(x => x.name).join(' > '));
 
@@ -73,7 +70,6 @@ oneNoteDataProvider.getNotebooks().then((notebooks) => {
 				onAccessibleSelection: (selectedItemId: string) => {
 					globalProps.globals.ariaSelectedId = selectedItemId;
 
-					// todo this changes the label but you can't click to make a selection?
 					render(globalProps, globalProps.globals.notebookListUpdater!.get());
 					renderDropdown(globalProps, globalProps.globals.notebookListUpdater!.get());
 				},
@@ -115,7 +111,7 @@ oneNoteDataProvider.getNotebooks().then((notebooks) => {
 	console.error(value);
 });
 
-export function findItemName(notebooks, itemid) {
-	let notebook = OneNoteItemUtils.find(notebooks, item => item.id === itemid);
+export function findItemName(notebooks, itemId) {
+	const notebook = OneNoteItemUtils.find(notebooks, item => item.id === itemId);
 	return notebook ? notebook.name : '';
 }

package.json

@@ -58,7 +58,7 @@ export abstract class GenericOneNotePickerDropdown<T extends PickerProperties> e
 		document.removeEventListener('mousedown', this.handleClickOutside);
 	}
 
-	abstract createTag(arg: T): JSX.Element;
+	abstract getPickerElement(arg: T): JSX.Element;
 
 	render() {
 		// TODO (machiam/jane) We should not modify props. We should copy to new object before passing it down.
@@ -98,7 +98,7 @@ export abstract class GenericOneNotePickerDropdown<T extends PickerProperties> e
 				</div>
 				{this.state.popupVisible ?
 					<div className={'picker-popup ' + (this.props.popupDirection === 'top' ? 'popup-upwards' : '')}>
-						{this.props.popupContentOverride ? this.props.popupContentOverride : this.createTag(this.props)}
+						{this.props.popupContentOverride ? this.props.popupContentOverride : this.getPickerElement(this.props)}
 					</div> :
 					undefined}
 			</div>
@@ -107,13 +107,13 @@ export abstract class GenericOneNotePickerDropdown<T extends PickerProperties> e
 }
 
 export class OneNotePickerDropdown extends GenericOneNotePickerDropdown<OneNotePickerProps & PickerProperties> {
-	createTag(args: OneNotePickerProps) {
+	getPickerElement(args: OneNotePickerProps) {
 		return <OneNotePicker {...args} />;
 	}
 }
 
 export class OneNoteSingleNotebookDropdown extends GenericOneNotePickerDropdown<OneNoteSingleNotebookPickerProps & PickerProperties> {
-	createTag(args: OneNoteSingleNotebookPickerProps) {
+	getPickerElement(args: OneNoteSingleNotebookPickerProps) {
 		return <OneNoteSingleNotebookPicker {...args} />;
 	}
 }