Skip to content

Commit 68d8e28

Browse files
authored
Merge pull request #377 from OneNoteDev/bug/remove-clip-anytime-in-fullpage-message
Remove clip anytime in fullpage message
2 parents 3b2329e + 2e32365 commit 68d8e28

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/scripts/clipperUI/clipperStateUtilities.ts

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export module ClipperStateUtilities {
2828
// but when the user clips, we short circuit it and display a message instead
2929
return true;
3030
case ClipMode.FullPage:
31+
// In the past, we used to allow clips while this is pending, however, we found some pages can't be clipped in full page mode
3132
let fullPageScreenshotResult = clipperState.fullPageResult;
3233
return fullPageScreenshotResult.status === Status.Succeeded;
3334
case ClipMode.Region:

src/scripts/clipperUI/components/previewViewer/fullPagePreview.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ class FullPagePreview extends PreviewComponentBase<{}, ClipperStateProp> {
9898
imageHeight={65}
9999
imageWidth={45}
100100
totalFrameCount={21}
101-
loop={true} />;
101+
loop={true}
102+
shouldDisplayMessage={false} />;
102103
return <div className={Constants.Classes.centeredInPreview}>{spinner}</div>;
103104
}
104105
}

0 commit comments

Comments
 (0)