From fee755445472d684d9045f1985c1324c9cef67a9 Mon Sep 17 00:00:00 2001
From: Rodrigo Gomez Palacio <rodrigo@onesignal.com>
Date: Thu, 16 Jan 2025 10:48:14 -0600
Subject: [PATCH] Add cache-busting query param when loading CSS and JS scripts

Motivation: depending on each user's site caching settings, they may not be getting updates to JS or CSS files as new versions come out.

Adding cache-busting helps fix that issue.
---
 v3/onesignal-admin/onesignal-admin.php     | 10 ++++++++--
 v3/onesignal-metabox/onesignal-metabox.php | 18 ++++++++++++++----
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/v3/onesignal-admin/onesignal-admin.php b/v3/onesignal-admin/onesignal-admin.php
index 73bc845..6b2c2e2 100644
--- a/v3/onesignal-admin/onesignal-admin.php
+++ b/v3/onesignal-admin/onesignal-admin.php
@@ -16,8 +16,14 @@ function onesignal_admin_menu()
 
 function admin_files()
 {
-  wp_enqueue_script('onesignal_admin_js', plugins_url('onesignal-admin.js', __FILE__));
-  wp_enqueue_style('style', plugins_url('onesignal-admin.css', __FILE__), array(), time());
+  $cache_buster = ceil(time() / 3600); // updates every hour
+  wp_enqueue_script(
+    'onesignal_admin_js',
+    plugins_url('onesignal-admin.js', __FILE__),
+    array(),
+    $cache_buster
+  );
+  wp_enqueue_style('style', plugins_url('onesignal-admin.css', __FILE__), array(), $cache_buster);
 }
 
 if (isset($_SERVER['REQUEST_METHOD']) && $_SERVER['REQUEST_METHOD'] === 'POST') {
diff --git a/v3/onesignal-metabox/onesignal-metabox.php b/v3/onesignal-metabox/onesignal-metabox.php
index 70e94bd..5f2a981 100644
--- a/v3/onesignal-metabox/onesignal-metabox.php
+++ b/v3/onesignal-metabox/onesignal-metabox.php
@@ -98,12 +98,22 @@ function onesignal_metabox($post)
 
 function onesignal_meta_files()
 {
-  wp_enqueue_script('onesignal_metabox_js', plugins_url('onesignal-metabox.js', __FILE__));
-  wp_enqueue_style('onesignal_metabox_css', plugins_url('onesignal-metabox.css', __FILE__), array(), time());
+  $cache_buster = ceil(time() / 3600); // updates every hour
+  wp_enqueue_script(
+    'onesignal_metabox_js',
+    plugins_url('onesignal-metabox.js', __FILE__),
+    array(),
+    $cache_buster,
+    true // load in the footer for performance
+  );
+  wp_enqueue_style(
+    'onesignal_metabox_css',
+    plugins_url('onesignal-metabox.css', __FILE__),
+    array(),
+    $cache_buster
+  );
 }
 
-
-
 // Store meta data
 add_action('save_post', 'onesignal_save_meta', 10);