Skip to content

Commit 0cdd45a

Browse files
committed
nit: remove methods from OSMessagingController header
* Aren't called by anything so no need to be on the interface, these are called by the class itself.
1 parent 22ee265 commit 0cdd45a

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.h

-5
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,13 @@ NS_ASSUME_NONNULL_BEGIN
4949

5050
+ (OSMessagingController *)sharedInstance;
5151
+ (void)start;
52-
+ (void)removeInstance;
53-
- (void)presentInAppMessage:(OSInAppMessageInternal *)message;
5452
- (void)getInAppMessagesFromServer:(NSString * _Nullable)subscriptionId;
55-
- (void)messageViewImpressionRequest:(OSInAppMessageInternal *)message;
56-
- (void)messageViewPageImpressionRequest:(OSInAppMessageInternal *)message withPageId:(NSString *)pageId;
5753

5854
- (BOOL)isInAppMessagingPaused;
5955
- (void)setInAppMessagingPaused:(BOOL)pause;
6056
- (void)addTriggers:(NSDictionary<NSString *, id> *)triggers;
6157
- (void)removeTriggersForKeys:(NSArray<NSString *> *)keys;
6258
- (void)clearTriggers;
63-
- (NSDictionary<NSString *, id> *)getTriggers;
6459

6560
- (void)addInAppMessageClickListener:(NSObject<OSInAppMessageClickListener> *_Nullable)listener;
6661
- (void)removeInAppMessageClickListener:(NSObject<OSInAppMessageClickListener> *_Nullable)listener;

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.m

+1
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ + (OSMessagingController *)sharedInstance {
165165
return sharedInstance;
166166
}
167167

168+
// TODO: Used by tests only? Come back and see if this is needed.
168169
+ (void)removeInstance {
169170
sharedInstance = nil;
170171
once = 0;

iOS_SDK/OneSignalSDK/UnitTests/Shadows/OSMessagingControllerOverrider.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ - (void)overrideShowMessage:(OSInAppMessageInternal *)message {
112112

113113
- (void)overrideWebViewContentFinishedLoading:(OSInAppMessageInternal *)message {
114114
if (message) {
115-
[OSMessagingController.sharedInstance messageViewImpressionRequest:message];
115+
// [OSMessagingController.sharedInstance messageViewImpressionRequest:message];
116116
}
117117
}
118118

0 commit comments

Comments
 (0)