[nits] privatize internal methods

* No need to be on protocol nor exposed

Author: nan-li

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSOperationExecutor.swift

@@ -32,11 +32,8 @@ import OneSignalCore
  */
 public protocol OSOperationExecutor {
     var supportedDeltas: [String] { get }
-    var deltaQueue: [OSDelta] { get }
 
     func enqueueDelta(_ delta: OSDelta)
     func cacheDeltaQueue()
     func processDeltaQueue(inBackground: Bool)
-
-    func processRequestQueue(inBackground: Bool)
 }

iOS_SDK/OneSignalSDK/OneSignalUser/Source/Executors/OSIdentityOperationExecutor.swift

@@ -30,11 +30,11 @@ import OneSignalCore
 
 class OSIdentityOperationExecutor: OSOperationExecutor {
     var supportedDeltas: [String] = [OS_ADD_ALIAS_DELTA, OS_REMOVE_ALIAS_DELTA]
-    var deltaQueue: [OSDelta] = []
+    private var deltaQueue: [OSDelta] = []
     // To simplify uncaching, we maintain separate request queues for each type
-    var addRequestQueue: [OSRequestAddAliases] = []
-    var removeRequestQueue: [OSRequestRemoveAlias] = []
-    let newRecordsState: OSNewRecordsState
+    private var addRequestQueue: [OSRequestAddAliases] = []
+    private var removeRequestQueue: [OSRequestRemoveAlias] = []
+    private let newRecordsState: OSNewRecordsState
 
     // The Identity executor dispatch queue, serial. This synchronizes access to the delta and request queues.
     private let dispatchQueue = DispatchQueue(label: "OneSignal.OSIdentityOperationExecutor", target: .global())
@@ -168,7 +168,7 @@ class OSIdentityOperationExecutor: OSOperationExecutor {
     }
 
     /// This method is called by `processDeltaQueue` only and does not need to be added to the dispatchQueue.
-    func processRequestQueue(inBackground: Bool) {
+    private func processRequestQueue(inBackground: Bool) {
         let requestQueue: [OneSignalRequest] = addRequestQueue + removeRequestQueue
 
         if requestQueue.isEmpty {

iOS_SDK/OneSignalSDK/OneSignalUser/Source/Executors/OSPropertyOperationExecutor.swift

@@ -62,9 +62,9 @@ private struct OSCombinedProperties {
 
 class OSPropertyOperationExecutor: OSOperationExecutor {
     var supportedDeltas: [String] = [OS_UPDATE_PROPERTIES_DELTA]
-    var deltaQueue: [OSDelta] = []
-    var updateRequestQueue: [OSRequestUpdateProperties] = []
-    let newRecordsState: OSNewRecordsState
+    private var deltaQueue: [OSDelta] = []
+    private var updateRequestQueue: [OSRequestUpdateProperties] = []
+    private let newRecordsState: OSNewRecordsState
 
     // The property executor dispatch queue, serial. This synchronizes access to `deltaQueue` and `updateRequestQueue`.
     private let dispatchQueue = DispatchQueue(label: "OneSignal.OSPropertyOperationExecutor", target: .global())
@@ -221,7 +221,7 @@ class OSPropertyOperationExecutor: OSOperationExecutor {
     }
 
     /// This method is called by `processDeltaQueue` only and does not need to be added to the dispatchQueue.
-    func processRequestQueue(inBackground: Bool) {
+    private func processRequestQueue(inBackground: Bool) {
         if updateRequestQueue.isEmpty {
             return
         }

iOS_SDK/OneSignalSDK/OneSignalUser/Source/Executors/OSSubscriptionOperationExecutor.swift

@@ -30,13 +30,13 @@ import OneSignalCore
 
 class OSSubscriptionOperationExecutor: OSOperationExecutor {
     var supportedDeltas: [String] = [OS_ADD_SUBSCRIPTION_DELTA, OS_REMOVE_SUBSCRIPTION_DELTA, OS_UPDATE_SUBSCRIPTION_DELTA]
-    var deltaQueue: [OSDelta] = []
+    private var deltaQueue: [OSDelta] = []
     // To simplify uncaching, we maintain separate request queues for each type
-    var addRequestQueue: [OSRequestCreateSubscription] = []
-    var removeRequestQueue: [OSRequestDeleteSubscription] = []
-    var updateRequestQueue: [OSRequestUpdateSubscription] = []
-    var subscriptionModels: [String: OSSubscriptionModel] = [:]
-    let newRecordsState: OSNewRecordsState
+    private var addRequestQueue: [OSRequestCreateSubscription] = []
+    private var removeRequestQueue: [OSRequestDeleteSubscription] = []
+    private var updateRequestQueue: [OSRequestUpdateSubscription] = []
+    private var subscriptionModels: [String: OSSubscriptionModel] = [:]
+    private let newRecordsState: OSNewRecordsState
 
     // The Subscription executor dispatch queue, serial. This synchronizes access to the delta and request queues.
     private let dispatchQueue = DispatchQueue(label: "OneSignal.OSSubscriptionOperationExecutor", target: .global())
@@ -157,7 +157,7 @@ class OSSubscriptionOperationExecutor: OSOperationExecutor {
     /**
      Since there are 2 subscription stores, we need to check both stores for the model with a particular `modelId`.
      */
-    func getSubscriptionModelFromStores(modelId: String) -> OSSubscriptionModel? {
+    private func getSubscriptionModelFromStores(modelId: String) -> OSSubscriptionModel? {
         if let modelInStore = OneSignalUserManagerImpl.sharedInstance.pushSubscriptionModelStore.getModel(modelId: modelId) {
             return modelInStore
         }
@@ -246,7 +246,7 @@ class OSSubscriptionOperationExecutor: OSOperationExecutor {
     }
 
     /// This method is called by `processDeltaQueue` only and does not need to be added to the dispatchQueue.
-    func processRequestQueue(inBackground: Bool) {
+    private func processRequestQueue(inBackground: Bool) {
         let requestQueue: [OneSignalRequest] = addRequestQueue + removeRequestQueue + updateRequestQueue
 
         if requestQueue.isEmpty {
@@ -269,7 +269,7 @@ class OSSubscriptionOperationExecutor: OSOperationExecutor {
         }
     }
 
-    func executeCreateSubscriptionRequest(_ request: OSRequestCreateSubscription, inBackground: Bool) {
+    private func executeCreateSubscriptionRequest(_ request: OSRequestCreateSubscription, inBackground: Bool) {
         guard !request.sentToClient else {
             return
         }
@@ -391,7 +391,7 @@ class OSSubscriptionOperationExecutor: OSOperationExecutor {
         }
     }
 
-    func executeUpdateSubscriptionRequest(_ request: OSRequestUpdateSubscription, inBackground: Bool) {
+    private func executeUpdateSubscriptionRequest(_ request: OSRequestUpdateSubscription, inBackground: Bool) {
         guard !request.sentToClient else {
             return
         }