Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Commit 55f61dd

Browse files
committed
fix(meet): generate signature from title instead of slug
Allows generating a new URL by e.g. adding punctuation
1 parent e281835 commit 55f61dd

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

lib/meetings/__init__.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ def _signature(s: str, *, secret: str) -> str:
4040

4141

4242
def _slug_with_signature(s: str, *, secret: str, slug_length=16):
43-
slug = slugify(s)
44-
return "-".join((slug, _signature(slug, secret=secret)[:slug_length]))
43+
return "-".join((slugify(s), _signature(s, secret=secret)[:slug_length]))
4544

4645

4746
def _pretty_uuid() -> str:
+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# name: test_create_jitsi_meet_deterministic_urls
2-
'https://meet.jit.si/practice-practice-practice-8ihjdtKucJlESm73'
2+
'https://meet.jit.si/practice-practice-practice-X0rhbi4w1bXFwd5H'
33
---

tests/test_meetings.py

+3
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,6 @@ def test_create_jitsi_meet_deterministic_urls(snapshot):
99
assert first == snapshot
1010
second = meetings.create_jitsi_meet(name, secret=SECRET)
1111
assert first == second
12+
13+
third = meetings.create_jitsi_meet("practice-practice-practice", secret=SECRET)
14+
assert first != third

0 commit comments

Comments
 (0)