feat(sign): make 'sign' the official lookup command; fix copy

Author: sloria

bot.py

@@ -113,7 +113,7 @@ async def on_ready():
 [🧬 **Lifeprint** - Search results]({lifeprint})
 [🤝 **SigningSavvy** - Sign for {word_uppercased}]({signingsavvy})
 [🌐 **Spread The Sign** - {word_uppercased}]({spread_the_sign})
-[📹 **YouGlish** - ASL videos containing {word_uppercased}]({youglish})
+[📹 **YouGlish** - Videos containing {word_uppercased}]({youglish})
 """
 
 HOWSIGN_SPOILER_TEMPLATE = """[👋 **Handspeak** - Search results]({handspeak})
@@ -151,7 +151,7 @@ def word_display(word: str, *, has_spoiler: bool):
     )
 
 
-def howsign_impl(word: str):
+def sign_impl(word: str):
     logger.info(f"sending links for: '{word}'")
     spoiler = get_spoiler_text(word)
     word = spoiler if spoiler else word
@@ -173,13 +173,13 @@ def howsign_impl(word: str):
     return {"embed": embed}
 
 
-@bot.command(name="howsign", aliases=("sign",), help=HOWSIGN_HELP)
-async def howsign_command(ctx: Context, *, word: str):
-    await ctx.send(**howsign_impl(word))
+@bot.command(name="sign", aliases=("howsign",), help=HOWSIGN_HELP)
+async def sign_command(ctx: Context, *, word: str):
+    await ctx.send(**sign_impl(word))
 
 
-@howsign_command.error
-async def howsign_error(ctx, error):
+@sign_command.error
+async def sign_error(ctx, error):
     if isinstance(error, commands.errors.MissingRequiredArgument):
         logger.info(f"missing argument to '{ctx.invoked_with}'")
         await ctx.send(

tests/__snapshots__/test_bot.ambr

@@ -116,7 +116,7 @@
     ',
   }
 ---
-# name: test_howsign[need, ask]
+# name: test_sign[need, ask]
   <class 'dict'> {
     'embed': <class 'Embed'> {
       Empty=Embed.Empty,
@@ -125,8 +125,8 @@
       colour=Embed.Empty,
       description=Embed.Empty,
       fields=<class 'list'> [
-        EmbedProxy(inline=True, name='NEED', value='[👋 **Handspeak** - Search results](https://www.google.com/search?&q=site%3Ahandspeak.com+need)\n[🧬 **Lifeprint** - Search results](https://www.google.com/search?&q=site%3Alifeprint.com+need)\n[🤝 **SigningSavvy** - Sign for NEED](https://www.signingsavvy.com/search/need)\n[🌐 **Spread The Sign** - NEED](https://www.spreadthesign.com/en.us/search/?q=need)\n[📹 **YouGlish** - ASL videos containing NEED](https://youglish.com/pronounce/need/signlanguage/asl)\n'),
-        EmbedProxy(inline=True, name='ASK', value='[👋 **Handspeak** - Search results](https://www.google.com/search?&q=site%3Ahandspeak.com+ask)\n[🧬 **Lifeprint** - Search results](https://www.google.com/search?&q=site%3Alifeprint.com+ask)\n[🤝 **SigningSavvy** - Sign for ASK](https://www.signingsavvy.com/search/ask)\n[🌐 **Spread The Sign** - ASK](https://www.spreadthesign.com/en.us/search/?q=ask)\n[📹 **YouGlish** - ASL videos containing ASK](https://youglish.com/pronounce/ask/signlanguage/asl)\n'),
+        EmbedProxy(inline=True, name='NEED', value='[👋 **Handspeak** - Search results](https://www.google.com/search?&q=site%3Ahandspeak.com+need)\n[🧬 **Lifeprint** - Search results](https://www.google.com/search?&q=site%3Alifeprint.com+need)\n[🤝 **SigningSavvy** - Sign for NEED](https://www.signingsavvy.com/search/need)\n[🌐 **Spread The Sign** - NEED](https://www.spreadthesign.com/en.us/search/?q=need)\n[📹 **YouGlish** - Videos containing NEED](https://youglish.com/pronounce/need/signlanguage/asl)\n'),
+        EmbedProxy(inline=True, name='ASK', value='[👋 **Handspeak** - Search results](https://www.google.com/search?&q=site%3Ahandspeak.com+ask)\n[🧬 **Lifeprint** - Search results](https://www.google.com/search?&q=site%3Alifeprint.com+ask)\n[🤝 **SigningSavvy** - Sign for ASK](https://www.signingsavvy.com/search/ask)\n[🌐 **Spread The Sign** - ASK](https://www.spreadthesign.com/en.us/search/?q=ask)\n[📹 **YouGlish** - Videos containing ASK](https://youglish.com/pronounce/ask/signlanguage/asl)\n'),
       ],
       footer=EmbedProxy(),
       image=EmbedProxy(),
@@ -140,7 +140,7 @@
     },
   }
 ---
-# name: test_howsign[tiger]
+# name: test_sign[tiger]
   <class 'dict'> {
     'embed': <class 'Embed'> {
       Empty=Embed.Empty,
@@ -152,7 +152,7 @@
         [🧬 **Lifeprint** - Search results](https://www.google.com/search?&q=site%3Alifeprint.com+tiger)
         [🤝 **SigningSavvy** - Sign for TIGER](https://www.signingsavvy.com/search/tiger)
         [🌐 **Spread The Sign** - TIGER](https://www.spreadthesign.com/en.us/search/?q=tiger)
-        [📹 **YouGlish** - ASL videos containing TIGER](https://youglish.com/pronounce/tiger/signlanguage/asl)
+        [📹 **YouGlish** - Videos containing TIGER](https://youglish.com/pronounce/tiger/signlanguage/asl)
 
       ',
       fields=<class 'list'> [
@@ -169,7 +169,7 @@
     },
   }
 ---
-# name: test_howsign[what's up]
+# name: test_sign[what's up]
   <class 'dict'> {
     'embed': <class 'Embed'> {
       Empty=Embed.Empty,
@@ -181,7 +181,7 @@
         [🧬 **Lifeprint** - Search results](https://www.google.com/search?&q=site%3Alifeprint.com+what%27s+up)
         [🤝 **SigningSavvy** - Sign for WHAT'S UP](https://www.signingsavvy.com/search/what%27s+up)
         [🌐 **Spread The Sign** - WHAT'S UP](https://www.spreadthesign.com/en.us/search/?q=what%27s+up)
-        [📹 **YouGlish** - ASL videos containing WHAT'S UP](https://youglish.com/pronounce/what%27s+up/signlanguage/asl)
+        [📹 **YouGlish** - Videos containing WHAT'S UP](https://youglish.com/pronounce/what%27s+up/signlanguage/asl)
 
       ',
       fields=<class 'list'> [
@@ -198,7 +198,7 @@
     },
   }
 ---
-# name: test_howsign[||need, ask||]
+# name: test_sign[||need, ask||]
   <class 'dict'> {
     'embed': <class 'Embed'> {
       Empty=Embed.Empty,
@@ -222,7 +222,7 @@
     },
   }
 ---
-# name: test_howsign[||tiger||]
+# name: test_sign[||tiger||]
   <class 'dict'> {
     'embed': <class 'Embed'> {
       Empty=Embed.Empty,
@@ -251,7 +251,7 @@
     },
   }
 ---
-# name: test_howsign[||what's up||]
+# name: test_sign[||what's up||]
   <class 'dict'> {
     'embed': <class 'Embed'> {
       Empty=Embed.Empty,

tests/test_bot.py

@@ -19,8 +19,8 @@
         "||need, ask||",
     ),
 )
-def test_howsign(snapshot, word):
-    result = bot.howsign_impl(word)
+def test_sign(snapshot, word):
+    result = bot.sign_impl(word)
     assert result == snapshot