Linter fixes and rule adjustments

Author: yungcomputerchair

.eslintrc.json

@@ -1,3 +1,8 @@
 {
-  "extends": ["next/core-web-vitals", "next/typescript"]
+  "extends": ["next/core-web-vitals", "next/typescript"],
+  "rules": {
+    "@typescript-eslint/no-unused-vars": "warn",
+    "@typescript-eslint/no-explicit-any": "warn",
+    "react-hooks/exhaustive-deps": "off"
+  }
 }

app/components/LauncherPage.tsx

@@ -1,4 +1,3 @@
-import { Container, Row, Col } from "react-bootstrap";
 import NavBar from "./NavBar";
 
 export default function LauncherPage({

app/components/LoginModal.tsx

@@ -1,4 +1,4 @@
-import { useState, useEffect, useRef } from "react";
+import { useState, useEffect } from "react";
 
 import Modal from "react-bootstrap/Modal";
 import Form from "react-bootstrap/Form";
@@ -106,6 +106,7 @@ function AnnouncementsPanel({ server }: { server?: ServerEntry }) {
         src={getUpsellImage(server)}
         className={!showUpsell ? "d-none" : ""}
         onLoad={() => setShowUpsell(true)}
+        alt="Upsell"
       />
       <div className="announcements">
         {error ? ERROR_TEXT : announcements.split('\n').map((line, index) => (
@@ -123,7 +124,7 @@ function RequirementsTooltip({
 }: {
   focusedControlId: string | null;
   controlId: string;
-  children: any;
+  children: React.ReactNode;
 }) {
   const target = document.getElementById(controlId);
   const show = !!(focusedControlId && focusedControlId === controlId);
@@ -285,7 +286,7 @@ export default function LoginModal({
               </Form.Group>
               <div className="text-center">
                 <span>
-                  View this server's{" "}
+                  View this server{"'s "}
                   <span
                     role="button"
                     className="text-decoration-underline"

app/components/ServerList.tsx

@@ -1,4 +1,4 @@
-import { ServerEntry, VersionEntry, Versions } from "@/app/types";
+import { ServerEntry, VersionEntry } from "@/app/types";
 import { useEffect, useState } from "react";
 import { invoke } from "@tauri-apps/api/core";
 
@@ -125,7 +125,7 @@ function VersionBadges({
           {endpointVersions.map((versionUuid) => {
             const version = findVersion(versions, versionUuid);
             if (!version) {
-              return <span className="badge bg-danger me-1">unknown</span>;
+              return <span key={versionUuid} className="badge bg-danger me-1">unknown</span>;
             }
             const label = version.name ?? version.uuid;
             return <span key={version.uuid} className="badge bg-success me-1">{label}</span>;

app/page.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import { startEasterEggs, stopEasterEggs } from "./easter-eggs";
+import { startEasterEggs } from "./easter-eggs";
 
 import { invoke } from "@tauri-apps/api/core";
 import { getVersion } from "@tauri-apps/api/app";
@@ -58,7 +58,6 @@ export default function Home() {
   const [versions, setVersions] = useState<VersionEntry[]>([]);
 
   const [alerts, setAlerts] = useState<Alert[]>([]);
-  const [notifications, setNotifications] = useState<Notification[]>([]);
   const [loadingTasks, setLoadingTasks] = useState<LoadingTask[]>([]);
 
   const [showAddModal, setShowAddModal] = useState(false);
@@ -249,10 +248,6 @@ export default function Home() {
     }
   };
 
-  const stub = () => {
-    alertInfo("hehe dong");
-  };
-
   const connectToServer = async (
     serverUuid: string,
     versionUuid: string,
@@ -342,7 +337,7 @@ export default function Home() {
       try {
         const loginSession: LoginSession = await invoke("get_session", { serverUuid: serverUuid });
         session = loginSession;
-      } catch (e: unknown) {
+      } catch {
         // If we can't get a session token for ANY REASON, we'll grab a new refresh token
         // by making the user log in again
         stopLoading("configure_endpoint");

app/settings/GameBuildsList.tsx

@@ -66,7 +66,7 @@ const getMissingTooltip = (items: Record<string, VersionCacheProgressItem>) => {
   }
 
   let tooltip = "Missing:\n";
-  for (const [name, item] of missingItems) {
+  for (const [name, _] of missingItems) {
     tooltip += `${name}\n`;
   }
   return tooltip;

app/util.ts

@@ -75,12 +75,10 @@ export function getHostnameFromLink(link: string) {
 let isDebugMode: boolean | undefined = undefined;
 export async function getDebugMode() {
   if (isDebugMode === undefined) {
-    try {
-      const debugOn: boolean = await invoke("is_debug_mode");
-      isDebugMode = debugOn;
-    } catch (e) {}
+    const debugOn: boolean = await invoke("is_debug_mode");
+    isDebugMode = debugOn;
   }
-  return isDebugMode ?? false;
+  return isDebugMode;
 }
 
 export function deepEqual(a: any, b: any) {