Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate optimized routines for ReverseProxyHttpService matching #70

Open
jesse-gallagher opened this issue Mar 17, 2021 · 0 comments
Labels
domino enhancement New feature or request

Comments

@jesse-gallagher
Copy link
Member

jesse-gallagher commented Mar 17, 2021

Currently, the isXspUrl and doService methods use a test like this to identify matches:

String pathInfo = getChompedPathInfo(fullPath);
boolean match = this.targets.keySet().stream()
	.anyMatch(contextRoot -> pathInfo.equals(contextRoot) || pathInfo.startsWith(contextRoot + '/'));

While that's fine, this is a performance-sensitive bit of code, and so it might be worth it to investigate a more-optimized routine for this, like what I think Undertow does internally.

@jesse-gallagher jesse-gallagher added enhancement New feature or request domino labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domino enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant