In HA failed SQL query block whole OpenNebula

[paczerny]

/!\ To report a security issue please follow this procedure:
[https://github.com/OpenNebula/one/wiki/Vulnerability-Management-Process]

Description
In HA environment. If there is a bug in write SQL query. The query is stored in replication queue, but as it fails, it's never replicated. The oned.log continuously show SQL error. It's not possible to create or modify any other resource.

To Reproduce
Let's use bug #6950, create VM with \t character in name. In HA setup:

onevm create --name a --cpu 1 --memory 128
onevm rename a "	b"     # This command fails as expected due to #6950
oneuser create a a             # This command should be executed normaly, but it fails

The oned.log continuously shows error in SQL query

Expected behavior
OpenNebula should detect failed SQL query on leader and should not replicate it on followers

Details

• Affected Component: oned, HA
• Version: master, 7.0

Additional context

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)