From e8ece98a109b948209b0ef59f620fa9662d4717d Mon Sep 17 00:00:00 2001
From: Bence Szigeti <bence.szigeti@gohyda.com>
Date: Tue, 23 Jan 2024 13:51:42 +0100
Subject: [PATCH] sql_cacher: fix SQL result leak when insert_in_cachedb fails

---
 modules/sql_cacher/sql_cacher.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/sql_cacher/sql_cacher.c b/modules/sql_cacher/sql_cacher.c
index 7ebde16b244..b3a258ae673 100644
--- a/modules/sql_cacher/sql_cacher.c
+++ b/modules/sql_cacher/sql_cacher.c
@@ -963,8 +963,9 @@ static int load_entire_table(cache_entry_t *c_entry, db_handlers_t *db_hdls,
 			if (!VAL_NULL(values)) {
 				if (insert_in_cachedb(c_entry, db_hdls, values ,values + 1,
 					reload_vers, ROW_N(row) - 1) < 0) {
+
 					lock_stop_write(db_hdls->c_entry->ref_lock);
-					return -1;
+					goto error;
 				}
 				loaded_rec++;
 			}