Skip to content

Commit 87374df

Browse files
authored
Apply suggestions from code review
1 parent 407e10b commit 87374df

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

doc/spec/basic_conventions.adoc

+6-1
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,9 @@ The model may have inputs, outputs, and parameters that are not specified by OSM
3333
Alternatively a model can be packaged as a valid FMU for co-simulation as specified in the FMI 3.0 standard cite:[fmi3.0].
3434
In this case, unless otherwise noted, all specifications in the FMI 3.0 cite:[fmi3.0] standard apply as-is.
3535

36-
The provisions above for FMI 2.0 apply, with the provision that the annotation shall be placed into the `<Annotations>` element of the `modelDescription.xml`.
36+
The rules above for FMI 2.0 apply, with the provision that the annotation shall be placed as an `<Annotation>` element into the `<Annotations>` element of the `modelDescription.xml`:
37+
38+
[source,xml]
39+
----
40+
<Annotation type="net.pmsf.osmp" xmlns:osmp="http://xsd.pmsf.net/OSISensorModelPackaging"><osmp:osmp version="1.4.0" osi-version="x.y.z"/></Annotation>
41+
----

doc/spec/binary_variables.adoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ The actual binary variable shall contain an annotation of the following form in
8787

8888
[source,xml]
8989
----
90-
<Tool name="net.pmsf.osmp" xmlns:osmp="http://xsd.pmsf.net/OSISensorModelPackaging"><osmp:osmp-binary-variable name="<prefix>" role="full" mime-type="<mime-type>"/></Tool>
90+
<Annotation type="net.pmsf.osmp" xmlns:osmp="http://xsd.pmsf.net/OSISensorModelPackaging"><osmp:osmp-binary-variable name="<prefix>" role="full" mime-type="<mime-type>"/></Annotation>
9191
----
9292

9393
`<prefix>` is the prefix as defined above.

0 commit comments

Comments
 (0)