-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible improvements on the Statistics graphs/plots of recorded tracks #2040
Comments
Any improvement of the diagrams would be nice. |
@dennisguse I wanted to jump into this thread, rather than have everything in the PR, so my apologies for the potential notification bombardment. Do the maintainers of this project have a preference for a charting library that they'd be interested in using? I would not be opposed to experimenting with something like https://github.com/patrykandpatrick/vico or just directly using Jetpack Compose as a basis for generating slightly nicer charts and opening a PR, but I also don't want to step on anyone's toes if they already have something else in mind for this app. |
The charts are more a convenience feature - usually data evaluation is done on a computer using software like https://github.com/SamR1/FitTrackee or https://www.goldencheetah.org/ If you want to work on this and try something out: have fun! Regarding libraries: not a strong fan to using libraries that are outside of Android's main line. Jetpack compose requires Kotlin and OpenTracks is completely in Java. PS/ At some point I was even thinking about removing the charts completely... PPS/ Another option would be to use the DashboardAPI and render the charts in another application (similar to OSM Dashboard). |
Ah, I see what you mean. And yep, I should have checked the language compatibility haha :) re: your PS - do you think that's for maintainability? I ask because I use this app specifically for tracking my heart rate, and seeing how the last 5-7 minutes went (and whether or not I maintained the HR zone I was shooting for) is very helpful for me. I was interested in at least adding a couple of useful features to this area, and hunting for a faster, easier chart solution. If in the long term you think this whole area might go away however, I'd rather spend my efforts elsewhere :) |
@grobolom that sounds like a problem the charts would not necessarily be well suited for. What about adding a new tab with proper UI for heartrates? PS/ charts may go away if the maintenance effort becomes too high. |
Hmm - that's not a bad idea. A dedicated HR chart would definitely make things easier. On the other hand, I could make several relatively simple (I hope) changes that would make them much more useable:
Between the two above elements and the ability to disable the other lines on the graph, I think it would make it quite useable without needing to rebuild the charts entirely. I'm happy to mess around with it and open a PR, and if it's not ideal then we'll reject it and do something else :) |
@grobolom sounds like a good plan :) |
Is your feature request related to a problem? Please describe.
The value of pace is difficult to read precisely from the graph as the y-axis limits are way to far from the average:
The green/blue color legend assigned to Elevation and Speed/pace is barely distinguishable with a light theme and eye protection (night filter) on.
Describe the solution you'd like
Plots of Elevation & pace from recorded tracks - either by time or by distance - could be improved in the following way:
Additional context
May be related to:
App version
v4.16.1
installed from f-droid on android 10 and used for tracking running sessions.The text was updated successfully, but these errors were encountered: