Fix for @abandonware/nobles breaking changes that cause: TypeError: this.noble.once is not a function.

Author: donavanbecker

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to this project will be documented in this file. This project uses [Semantic Versioning](https://semver.org/)
 
+## [Version 1.7.1](https://github.com/OpenWonderLabs/node-switchbot/releases/tag/v1.7.1) (2022-12-20)
+
+## What's Changed
+
+- Fix for @abandonware/nobles breaking changes that cause: `TypeError: this.noble.once is not a function`.
+
+**Full Changelog**: https://github.com/OpenWonderLabs/node-switchbot/compare/v1.7.0...v1.7.1
+
 ## [Version 1.7.0](https://github.com/OpenWonderLabs/node-switchbot/releases/tag/v1.7.0) (2022-12-08)
 
 ## What's Changed

errros.log

@@ -0,0 +1,13 @@
+
+/usr/local/lib/node_modules/@switchbot/homebridge-switchbot/node_modules/node-switchbot/node_modules/@abandonware/noble/lib/noble.js:137
+      this._bindings.startScanning(serviceUuids, allowDuplicates);
+                     ^
+TypeError: A string was expected
+    at Noble.scan (/usr/local/lib/node_modules/@switchbot/homebridge-switchbot/node_modules/node-switchbot/node_modules/@abandonware/noble/lib/noble.js:137:22)
+    at Noble.startScanning (/usr/local/lib/node_modules/@switchbot/homebridge-switchbot/node_modules/node-switchbot/node_modules/@abandonware/noble/lib/noble.js:149:10)
+    at /usr/local/lib/node_modules/@switchbot/homebridge-switchbot/node_modules/node-switchbot/node_modules/@abandonware/noble/lib/noble.js:155:44
+    at node:internal/util:364:7
+    at new Promise (<anonymous>)
+    at node:internal/util:350:12
+    at Noble.startScanningAsync (/usr/local/lib/node_modules/@switchbot/homebridge-switchbot/node_modules/node-switchbot/node_modules/@abandonware/noble/lib/noble.js:155:99)
+    at /usr/local/lib/node_modules/@switchbot/homebridge-switchbot/node_modules/node-switchbot/lib/switchbot.js:374:22

lib/switchbot-device.js

@@ -131,7 +131,7 @@ class SwitchbotDevice {
       });
 
       // Connect
-      this._peripheral.connect((error) => {
+      this._peripheral.connectAsync((error) => {
         if (error) {
           reject(error);
           return;
@@ -145,7 +145,7 @@ class SwitchbotDevice {
             resolve();
           })
           .catch((error) => {
-            this._peripheral.disconnect();
+            this._peripheral.disconnectAsync();
             reject(error);
           });
       });
@@ -224,7 +224,7 @@ class SwitchbotDevice {
 
   _discoverServices() {
     return new Promise((resolve, reject) => {
-      this._peripheral.discoverServices([], (error, service_list) => {
+      this._peripheral.discoverServicesAsync([], (error, service_list) => {
         if (error) {
           reject(error);
           return;
@@ -321,7 +321,7 @@ class SwitchbotDevice {
       // Unsubscribe
       this._unsubscribe().then(() => {
         // Disconnect
-        this._peripheral.disconnect(() => {
+        this._peripheral.disconnectAsync(() => {
           resolve();
         });
       });

lib/switchbot.js

@@ -30,7 +30,7 @@ class Switchbot {
     if (params && params.noble) {
       noble = params.noble;
     } else {
-      noble = require("@abandonware/noble");
+      noble = require('@abandonware/noble')({extended: false});
     }
 
     // Public properties
@@ -127,7 +127,7 @@ class Switchbot {
               clearTimeout(timer);
             }
             this.noble.removeAllListeners("discover");
-            this.noble.stopScanning();
+            this.noble.stopScanningAsync(() => process.exit());
             let device_list = [];
             for (let addr in peripherals) {
               device_list.push(peripherals[addr]);
@@ -155,7 +155,7 @@ class Switchbot {
           });
 
           // Start scanning
-          this.noble.startScanning(
+          this.noble.startScanningAsync(
             this._PRIMARY_SERVICE_UUID_LIST,
             false,
             (error) => {
@@ -167,7 +167,7 @@ class Switchbot {
                 finishDiscovery();
               }, p.duration);
             }
-          );
+          , false);
         })
         .catch((error) => {
           reject(error);
@@ -371,7 +371,7 @@ class Switchbot {
           });
 
           // Start scanning
-          this.noble.startScanning(
+          this.noble.startScanningAsync(
             this._PRIMARY_SERVICE_UUID_LIST,
             true,
             (error) => {
@@ -381,7 +381,7 @@ class Switchbot {
                 resolve();
               }
             }
-          );
+          , false);
         })
         .catch((error) => {
           reject(error);
@@ -402,7 +402,7 @@ class Switchbot {
    * ---------------------------------------------------------------- */
   stopScan() {
     this.noble.removeAllListeners("discover");
-    this.noble.stopScanning();
+    this.noble.stopScanningAsync(() => process.exit());
   }
 
   /* ------------------------------------------------------------------