Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Refactor notifications #336

Open
FinnWoelm opened this issue Feb 18, 2019 · 0 comments
Open

Refactor notifications #336

FinnWoelm opened this issue Feb 18, 2019 · 0 comments
Labels
refactor Issues about refactoring code

Comments

@FinnWoelm
Copy link
Contributor

  • To add a new notification, we need to create a helper, a view, and two mailers — but 50%+ of these files is identical to the other notification files.
  • The integration tests added to models to verify that notifications are sent are very slow and should be reduced and then refactored into a shared example
@FinnWoelm FinnWoelm added the refactor Issues about refactoring code label Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Issues about refactoring code
Projects
None yet
Development

No branches or pull requests

1 participant