Skip to content

Commit 375541e

Browse files
alexjoel42alexjoel42
committed
we fixed the feature flags
1 parent cd278e1 commit 375541e

File tree

5 files changed

+7
-87
lines changed

5 files changed

+7
-87
lines changed

‎protocol-designer/cypress/e2e/GEN2P20SignleOT2.cy.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,6 @@ import { StepBuilder } from '../support/StepBuilder'
33
import { getTestFile, TestFilePath } from '../support/TestFiles'
44

55
describe('P20 single-channel OT-2 Transfers', () => {
6-
beforeEach(() => {
7-
console.log('enablePrereleaseMode()')
8-
cy.visit('/')
9-
cy.verifyHomePage()
10-
cy.closeAnalyticsModal()
11-
cy.window().then(win => {
12-
if (typeof win.enablePrereleaseMode === 'function') {
13-
console.log('Calling enablePrereleaseMode()') // Optional: Keep the console log for visual confirmation in the test runner
14-
win.enablePrereleaseMode()
15-
} else {
16-
console.warn(
17-
'Warning: enablePrereleaseMode function not found on the window object.'
18-
)
19-
}
20-
})
21-
})
226
/**
237
* It covers all combinations of the predefined liquid classes and volumes (12 total transfers).
248
* Each transfer uses a sequential well from A1 to A12.
@@ -200,9 +184,6 @@ describe('P20 single-channel OT-2 Transfers', () => {
200184
const protocol = getTestFile(TestFilePath.GEN2P300SingleOT2)
201185
cy.importProtocol(protocol.path)
202186
cy.contains('Confirm').click()
203-
cy.openSettingsPage()
204-
cy.get('[aria-label="Settings_OT_PD_ENABLE_LIQUID_CLASSES"]').click()
205-
cy.openSettingsPage()
206187
cy.contains('Edit protocol').click()
207188
const steps = new StepBuilder()
208189

‎protocol-designer/cypress/e2e/P1000MTransferMulti.cy.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,13 @@ describe('Transfer stepform testing P1000M', () => {
1111
cy.visit('/')
1212
cy.verifyHomePage()
1313
cy.closeAnalyticsModal()
14-
cy.window().then(win => {
15-
if (typeof win.enablePrereleaseMode === 'function') {
16-
console.log('Calling enablePrereleaseMode()')
17-
win.enablePrereleaseMode()
18-
} else {
19-
console.warn(
20-
'Warning: enablePrereleaseMode function not found on the window object.'
21-
)
22-
}
23-
})
2414

2515
// This is the "COMMON SETUP FOR IT BLOCKS" that should run once
2616
// before each 'it' block, directly within this beforeEach.
2717
const protocol = getTestFile(TestFilePath.P1000MTransferMulti)
2818
cy.importProtocol(protocol.path)
2919
cy.contains('Confirm').click()
3020
cy.openSettingsPage()
31-
cy.get('[aria-label="Settings_OT_PD_ENABLE_LIQUID_CLASSES"]').click()
32-
cy.openSettingsPage()
3321
cy.contains('Edit protocol').click()
3422
// Add an assertion to confirm we are in the expected state, e.g.,
3523
cy.contains('Add Step').should('be.visible')
@@ -67,11 +55,11 @@ describe('Transfer stepform testing P1000M', () => {
6755
for (const tip of tips) {
6856
let volumes: string[] = []
6957
if (tip === '50') {
70-
volumes = ['5', '10', '50']
58+
volumes = ['7', '14', '48']
7159
} else if (tip === '200') {
72-
volumes = ['5', '50', '200']
60+
volumes = ['8', '44', '199']
7361
} else if (tip === '1000') {
74-
volumes = ['10', '100', '1000']
62+
volumes = ['11', '101', '999']
7563
}
7664

7765
for (const volume of volumes) {

‎protocol-designer/cypress/e2e/P1000STransfer.cy.ts

Lines changed: 3 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -8,30 +8,8 @@ describe('Transfer stepform testing Single Channel P1000uL', () => {
88
cy.visit('/')
99
cy.verifyHomePage()
1010
cy.closeAnalyticsModal()
11-
cy.window().then(win => {
12-
if (typeof win.enablePrereleaseMode === 'function') {
13-
console.log('Calling enablePrereleaseMode()') // Optional: Keep the console log for visual confirmation in the test runner
14-
win.enablePrereleaseMode()
15-
} else {
16-
console.warn(
17-
'Warning: enablePrereleaseMode function not found on the window object.'
18-
)
19-
}
20-
})
2111
})
2212

23-
const getAllWells = (): string[] => {
24-
const allWells: string[] = []
25-
const rows = 'ABCDEFGH'
26-
const cols = Array.from({ length: 12 }, (_, i) => i + 1)
27-
for (const row of rows) {
28-
for (const col of cols) {
29-
allWells.push(`${row}${col}`)
30-
}
31-
}
32-
return allWells
33-
}
34-
3513
/**
3614
* Generates multiple transfer steps for a single-channel pipette,
3715
* covering combinations of liquid classes, tip sizes, and volumes.
@@ -87,11 +65,11 @@ describe('Transfer stepform testing Single Channel P1000uL', () => {
8765
for (const tip of tips) {
8866
let volumes: string[] = []
8967
if (tip === '50') {
90-
volumes = ['5', '10', '50']
68+
volumes = ['6', '22.1', '48']
9169
} else if (tip === '200') {
92-
volumes = ['5', '50', '200']
70+
volumes = ['5', '48', '197']
9371
} else if (tip === '1000') {
94-
volumes = ['10', '100', '1000']
72+
volumes = ['12', '111', '944']
9573
}
9674

9775
for (const volume of volumes) {
@@ -138,9 +116,6 @@ describe('Transfer stepform testing Single Channel P1000uL', () => {
138116
const protocol = getTestFile(TestFilePath.P1000STransferSingle)
139117
cy.importProtocol(protocol.path)
140118
cy.contains('Confirm').click()
141-
cy.openSettingsPage()
142-
cy.get('[aria-label="Settings_OT_PD_ENABLE_LIQUID_CLASSES"]').click()
143-
cy.openSettingsPage()
144119
cy.contains('Edit protocol').click()
145120
const steps = new StepBuilder()
146121
GenerateMultipleTransferStepsForSingleChannel(

‎protocol-designer/cypress/e2e/P50MTransfer.cy.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,6 @@ describe('Transfer stepform testing Single Channel - Spicy Sequential Wells', ()
88
cy.visit('/')
99
cy.verifyHomePage()
1010
cy.closeAnalyticsModal()
11-
cy.window().then(win => {
12-
if (typeof win.enablePrereleaseMode === 'function') {
13-
console.log('Calling enablePrereleaseMode()') // Optional: Keep the console log for visual confirmation in the test runner
14-
win.enablePrereleaseMode()
15-
} else {
16-
console.warn(
17-
'Warning: enablePrereleaseMode function not found on the window object.'
18-
)
19-
}
20-
})
2111
})
2212
/**
2313
* Generates multiple transfer steps specifically for a P50 8-channel pipette.
@@ -39,7 +29,7 @@ describe('Transfer stepform testing Single Channel - Spicy Sequential Wells', ()
3929
destinationLabware2: string
4030
) => {
4131
const tip: string = '50' // Fixed tip for P50
42-
const volumes: string[] = ['5', '20', '50'] // Fixed volumes for P50
32+
const volumes: string[] = ['4', '19', '49'] // Fixed volumes for P50
4333
const liquidClasses: string[] = [
4434
"Don't use a liquid class",
4535
'Aqueous',
@@ -106,8 +96,6 @@ describe('Transfer stepform testing Single Channel - Spicy Sequential Wells', ()
10696
cy.importProtocol(protocol.path)
10797
cy.contains('Confirm').click()
10898
cy.openSettingsPage()
109-
cy.get('[aria-label="Settings_OT_PD_ENABLE_LIQUID_CLASSES"]').click()
110-
cy.openSettingsPage()
11199
cy.contains('Edit protocol').click()
112100
const steps = new StepBuilder()
113101
/* Commenting out for now for E2E

‎protocol-designer/cypress/e2e/transferSettings.cy.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,6 @@ describe('Transfer stepform testing Single Channel - Spicy Sequential Wells', ()
1313
cy.visit('/')
1414
cy.verifyHomePage()
1515
cy.closeAnalyticsModal()
16-
cy.window().then(win => {
17-
if (typeof win.enablePrereleaseMode === 'function') {
18-
console.log('Calling enablePrereleaseMode()') // Optional: Keep the console log for visual confirmation in the test runner
19-
win.enablePrereleaseMode()
20-
} else {
21-
console.warn(
22-
'Warning: enablePrereleaseMode function not found on the window object.'
23-
)
24-
}
25-
})
2616
})
2717

2818
const getAllWells = (): string[] => {
@@ -75,8 +65,6 @@ describe('Transfer stepform testing Single Channel - Spicy Sequential Wells', ()
7565
cy.importProtocol(protocol.path)
7666
cy.contains('Confirm').click()
7767
cy.openSettingsPage()
78-
cy.get('[aria-label="Settings_OT_PD_ENABLE_LIQUID_CLASSES"]').click()
79-
cy.openSettingsPage()
8068
cy.contains('Edit protocol').click()
8169
/*
8270
cy.contains('Add Step').click()

0 commit comments

Comments
 (0)