Improve test coverage (#142)

Improve test coverage

Author: Digbigpig

app/api/routes.py

@@ -1,8 +1,5 @@
-from traceback import print_tb
-
 from flask import request, redirect
 from sqlalchemy import or_, func
-from sqlalchemy.orm.exc import NoResultFound
 
 from app.api import bp
 from app.api.auth import is_user_oc_member, authenticate
@@ -99,14 +96,7 @@ def apikey():
 
 # Helpers
 def get_resource(id):
-    resource = None
-    try:
-        resource = Resource.query.get(id)
-
-    except NoResultFound as e:
-        print_tb(e.__traceback__)
-        logger.exception(e)
-        return redirect('/404')
+    resource = Resource.query.get(id)
 
     if resource:
         return standardize_response(payload=dict(data=(resource.serialize)))
@@ -245,22 +235,12 @@ def get_attributes(json):
 
 
 def update_votes(id, vote_direction):
-    try:
-        resource = Resource.query.get(id)
 
-        if not resource:
-            return redirect('/404')
+    resource = Resource.query.get(id)
 
-    except NoResultFound as e:
-        print_tb(e.__traceback__)
-        logger.exception(e)
+    if not resource:
         return redirect('/404')
 
-    except Exception as e:
-        print_tb(e.__traceback__)
-        logger.exception(e)
-        return standardize_response(status_code=500)
-
     initial_count = getattr(resource, vote_direction)
     setattr(resource, vote_direction, initial_count+1)
     db.session.commit()
@@ -269,22 +249,11 @@ def update_votes(id, vote_direction):
 
 
 def add_click(id):
-    try:
-        resource = Resource.query.get(id)
-
-        if not resource:
-            return redirect('/404')
+    resource = Resource.query.get(id)
 
-    except NoResultFound as e:
-        print_tb(e.__traceback__)
-        logger.exception(e)
+    if not resource:
         return redirect('/404')
 
-    except Exception as e:
-        print_tb(e.__traceback__)
-        logger.exception(e)
-        return standardize_response(status_code=500)
-
     initial_count = getattr(resource, 'times_clicked')
     setattr(resource, 'times_clicked', initial_count + 1)
     db.session.commit()
@@ -293,7 +262,6 @@ def add_click(id):
 
 
 def set_resource(id, json, db):
-    resource = None
     resource = Resource.query.get(id)
 
     if not resource:

app/cli.py

@@ -7,7 +7,7 @@
 from .models import Category, Language, Resource
 
 
-def import_resources(db):
+def import_resources(db):   # pragma: no cover
     # Step 1: Get data
     with open('resources.yml', encoding='utf-8') as f:
         data = yaml.full_load(f)
@@ -115,7 +115,7 @@ def create_resource(resource, db):
         print('exception', e)
 
 
-def update_resource(resource, existing_resource):
+def update_resource(resource, existing_resource):   # pragma: no cover
     existing_resource.name = resource['name']
     existing_resource.url = resource['url']
     existing_resource.category = resource['category']
@@ -124,7 +124,7 @@ def update_resource(resource, existing_resource):
     existing_resource.languages = resource['languages']
 
 
-def register(app, db):
+def register(app, db):  # pragma: no cover
     @app.cli.group()
     def db_migrate():
         """ migration commands"""

app/utils.py

@@ -97,7 +97,7 @@ def standardize_response(payload={}, status_code=200):
 def setup_logger(name, log_file, level=logging.INFO):
     """Function setup as many loggers as you want"""
     if not os.path.exists('log'):
-        os.makedirs('log')
+        os.makedirs('log')  # pragma: no cover
 
     formatter = logging.Formatter('%(asctime)s %(levelname)s %(message)s')
     handler = logging.FileHandler(log_file)

tests/unit/test_routes.py

@@ -83,11 +83,11 @@ def test_single_resource_out_of_bounds(module_client, module_db):
 
     too_low = 0
     too_high = 9999
-    response = client.get(f"api/v1/resources{too_low}")
+    response = client.get(f"api/v1/resources/{too_low}", follow_redirects=True)
 
     assert (response.status_code == 404)
 
-    response = client.get(f"api/v1/resources{too_high}")
+    response = client.get(f"api/v1/resources/{too_high}", follow_redirects=True)
 
     assert (response.status_code == 404)
 
@@ -417,6 +417,7 @@ def test_key_query_error(module_client, module_db, fake_auth_from_oc, fake_key_q
     ))
     assert (response.status_code == 500)
 
+
 def test_internal_server_error_handler(module_client, module_db, fake_paginated_data_error):
     client = module_client
 
@@ -433,6 +434,13 @@ def test_internal_server_error_handler(module_client, module_db, fake_paginated_
     assert (response.json['errors'][0].get("code") == "server-error")
 
 
+def test_method_not_allowed_handler(module_client):
+    client = module_client
+
+    response = client.patch('api/v1/resources')
+    assert (response.status_code == 405)
+    assert (response.json['errors'][0].get("code") == "method-not-allowed")
+
 ##########################################
 ## Other Routes
 ##########################################