Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self influence #8

Merged
merged 17 commits into from
Dec 17, 2024
Merged

Self influence #8

merged 17 commits into from
Dec 17, 2024

Conversation

tfjgeorge
Copy link
Collaborator

No description provided.

@tfjgeorge
Copy link
Collaborator Author

in summary, this unifies the @linear api to a single LinearModel class, with 'log_loss' and 'l2' loss currently implemented:

  • adds tests vs LOO
  • adds support for binary classification (whereas previously it was handled as a multiclass classification using softmax)
  • grad_y and grad_p methods
  • the influence probe is renamed SelfInfluence
  • removes untested classifiers
  • updates TracIn and GradSimilarity in accordance

Possible regression: sparse feature matrices

Copy link
Collaborator

@pierrenodet pierrenodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very clean :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good (besides trees, but we can look into that later), but what's up with the scales in the last plot?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea :-D I agree that it looks suspicious

@tfjgeorge tfjgeorge merged commit 810dfdf into master Dec 17, 2024
2 checks passed
@tfjgeorge tfjgeorge deleted the self_influence branch December 17, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants